Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isSearchable not evaluated for set of enum and set of localized enum attributes #46

Closed
stmeissner opened this issue Oct 31, 2016 · 4 comments
Closed

isSearchable not evaluated for set of enum and set of localized enum attributes #46

stmeissner opened this issue Oct 31, 2016 · 4 comments
Assignees
@junajan

Comments

@stmeissner
Copy link

when having an set:enum or set:lenum type attributes defined as isSearchable = "true" in the attributes CSV file, the resulting JSON file contains the flag "isSearchable": false"
@stmeissner stmeissner added the bug label Oct 31, 2016
@junajan
Copy link
Contributor

junajan commented Nov 21, 2016

@stmeissner @hajoeichler - In the code there is a condition which sets isSearchable and isRequired to false when the type is set:
https://github.com/sphereio/sphere-product-type-json-generator/blob/master/src/coffee/product-type-generator.coffee#L118

Is it a correct behavior? Or should I remove this condition?

@stmeissner
Copy link
Author

yep @junajan, SetType attributes are searchable, but cannot be required:
https://dev.commercetools.com/http-api-projects-productTypes.html#settype

junajan added a commit that referenced this issue Nov 21, 2016
@junajan
fix(generator): Fix isSearchable on set attributes - issue #46
ec29a81
@junajan junajan mentioned this issue Nov 21, 2016
Merged
@junajan
Copy link
Contributor

junajan commented Nov 21, 2016

Fixed here #49.

junajan added a commit that referenced this issue Nov 21, 2016
@junajan
test(generator): Add test for isSearchable issue #46
22de4bf
@junajan junajan self-assigned this Nov 21, 2016
junajan added a commit that referenced this issue Nov 21, 2016
@junajan
Merge pull request #49 from sphereio/issue-46
0c52642 
fix(generator): Fix isSearchable on set attributes - issue #46
@junajan
Copy link
Contributor

junajan commented Nov 21, 2016

merged

@junajan junajan closed this as completed Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junajan junajan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stmeissner @junajan