Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon button changes #2758

Merged
merged 2 commits into from Mar 22, 2024
Merged

Icon button changes #2758

merged 2 commits into from Mar 22, 2024

Conversation

ddouglasz
Copy link
Contributor

Summary

Icon button changes

2024-03-21 20 31 44

When disabled:
2024-03-21 20 34 12

@ddouglasz ddouglasz requested a review from a team as a code owner March 21, 2024 19:35
Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: be9b81f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 95 packages
Name Type
@commercetools-uikit/icon-button Major
@commercetools-uikit/design-system Major
@commercetools-uikit/field-label Major
@commercetools-uikit/buttons Major
@commercetools-uikit/calendar-utils Major
@commercetools-uikit/avatar Major
@commercetools-uikit/card Major
@commercetools-uikit/collapsible-panel Major
@commercetools-uikit/constraints Major
@commercetools-uikit/data-table-manager Major
@commercetools-uikit/data-table Major
@commercetools-uikit/icons Major
@commercetools-uikit/label Major
@commercetools-uikit/link Major
@commercetools-uikit/loading-spinner Major
@commercetools-uikit/notifications Major
@commercetools-uikit/pagination Major
@commercetools-uikit/primary-action-dropdown Major
@commercetools-uikit/progress-bar Major
@commercetools-uikit/stamp Major
@commercetools-uikit/tag Major
@commercetools-uikit/text Major
@commercetools-uikit/tooltip Major
@commercetools-uikit/view-switcher Major
@commercetools-uikit/accessible-button Major
@commercetools-uikit/flat-button Major
@commercetools-uikit/link-button Major
@commercetools-uikit/primary-button Major
@commercetools-uikit/secondary-button Major
@commercetools-uikit/secondary-icon-button Major
@commercetools-uikit/async-creatable-select-field Major
@commercetools-uikit/async-select-field Major
@commercetools-uikit/creatable-select-field Major
@commercetools-uikit/date-field Major
@commercetools-uikit/date-range-field Major
@commercetools-uikit/date-time-field Major
@commercetools-uikit/localized-multiline-text-field Major
@commercetools-uikit/localized-text-field Major
@commercetools-uikit/money-field Major
@commercetools-uikit/multiline-text-field Major
@commercetools-uikit/number-field Major
@commercetools-uikit/password-field Major
@commercetools-uikit/radio-field Major
@commercetools-uikit/search-select-field Major
@commercetools-uikit/select-field Major
@commercetools-uikit/text-field Major
@commercetools-uikit/time-field Major
@commercetools-uikit/async-creatable-select-input Major
@commercetools-uikit/async-select-input Major
@commercetools-uikit/checkbox-input Major
@commercetools-uikit/creatable-select-input Major
@commercetools-uikit/date-input Major
@commercetools-uikit/date-range-input Major
@commercetools-uikit/date-time-input Major
@commercetools-uikit/input-utils Major
@commercetools-uikit/localized-money-input Major
@commercetools-uikit/localized-multiline-text-input Major
@commercetools-uikit/localized-rich-text-input Major
@commercetools-uikit/localized-text-input Major
@commercetools-uikit/money-input Major
@commercetools-uikit/multiline-text-input Major
@commercetools-uikit/number-input Major
@commercetools-uikit/password-input Major
@commercetools-uikit/radio-input Major
@commercetools-uikit/rich-text-input Major
@commercetools-uikit/rich-text-utils Major
@commercetools-uikit/search-select-input Major
@commercetools-uikit/search-text-input Major
@commercetools-uikit/select-input Major
@commercetools-uikit/select-utils Major
@commercetools-uikit/selectable-search-input Major
@commercetools-uikit/text-input Major
@commercetools-uikit/time-input Major
@commercetools-uikit/toggle-input Major
@commercetools-uikit/spacings-inline Major
@commercetools-uikit/spacings-inset-squish Major
@commercetools-uikit/spacings-inset Major
@commercetools-uikit/spacings-stack Major
@commercetools-frontend/ui-kit Major
visual-testing-app Patch
@commercetools-uikit/messages Major
@commercetools-uikit/fields Major
@commercetools-uikit/inputs Major
@commercetools-uikit/spacings Major
@commercetools-uikit/field-errors Major
@commercetools-uikit/field-warnings Major
@commercetools-uikit/calendar-time-utils Major
@commercetools-uikit/hooks Major
@commercetools-uikit/i18n Major
@commercetools-uikit/localized-utils Major
@commercetools-uikit/utils Major
@commercetools-uikit/accessible-hidden Major
@commercetools-uikit/collapsible-motion Major
@commercetools-uikit/collapsible Major
@commercetools-uikit/grid Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview Mar 21, 2024 7:35pm

@ddouglasz ddouglasz requested a review from a team March 22, 2024 08:37
@CarlosCortizasCT
Copy link
Contributor

Looks good to me but I wanted to double check with @FilPob about the border being removed in the new theme not only for the default button theme but also for the info and primary ones

@FilPob
Copy link

FilPob commented Mar 22, 2024

@CarlosCortizasCT didnt even see that the border is there in the old theme :) so yes, no border for info and primary in the new theme

Copy link
Contributor

@chloe0592 chloe0592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ddouglasz!

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ddouglasz ddouglasz merged commit e694890 into main Mar 22, 2024
6 checks passed
@ddouglasz ddouglasz deleted the SHIELD-1148-icon-button-update-styles branch March 22, 2024 10:54
@ct-changesets ct-changesets bot mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants