Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): for release v6.0.0 #390

Merged
merged 5 commits into from
Jan 8, 2019
Merged

docs(changelog): for release v6.0.0 #390

merged 5 commits into from
Jan 8, 2019

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Jan 5, 2019

Based on this diff: v5.0.0...master

@emmenko
Copy link
Member Author

emmenko commented Jan 5, 2019

Do we plan to include other pending stuff into the next release or can we proceed with it?

For example, #389 has also breaking changes...

@montezume
Copy link
Contributor

I would like to get #387 in as well, and I think we are really close with #339

@dferber90
Copy link
Contributor

#389 is ready code-wise as well. It's only missing some reviews.

Whether we should wait for #389 mostly depends on whether we want to do one big upgrade of the MC or two successive smaller ones. I'm fine either way, but I'd rather get #389 in as well.

@emmenko
Copy link
Member Author

emmenko commented Jan 5, 2019

Cool, let's try to get this out in the next days then! 🚀

Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready when you are 🚀

Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This change log reads really nicely!

@dferber90
Copy link
Contributor

Ah damn, the docs for changes of #389 are missing!

@dferber90
Copy link
Contributor

Added the #389 stuff now. @montezume is still doing some fixes and then we're ready for the next release.

@montezume
Copy link
Contributor

Okay I updated the changelog with the last two PRs. I think we are ready to go @emmenko @dferber90

Copy link
Member Author

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@montezume montezume merged commit d942ae3 into master Jan 8, 2019
@montezume montezume deleted the nm-changelog-6.0.0 branch January 8, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants