Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select-input): fix for prop type #692

Merged
merged 3 commits into from
Apr 17, 2019
Merged

fix(select-input): fix for prop type #692

merged 3 commits into from
Apr 17, 2019

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Apr 17, 2019 •
edited

Summary

We can't use PropTypes.element because that defines a react element.

We can't use Element because it's undefined in node and crashes the MC at compile time.

More info here

@montezume montezume self-assigned this Apr 17, 2019
emmenko
emmenko reviewed Apr 17, 2019
View reviewed changes
src/utils/get-element.js Outdated Show resolved Hide resolved
emmenko
emmenko approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@montezume montezume merged commit 62e9599 into master Apr 17, 2019
@montezume montezume deleted the ml-proptype-fix branch April 17, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@montezume montezume

Labels
🔮 Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@montezume @emmenko @tdeekens