Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX license descriptors by default #136

Closed
dbaynard opened this issue Dec 3, 2018 · 4 comments
Closed

Use SPDX license descriptors by default #136

dbaynard opened this issue Dec 3, 2018 · 4 comments

Comments

@dbaynard
Copy link

dbaynard commented Dec 3, 2018

At least the default template uses BSD3 for a license identifier. Cabal now supports SPDX license identifiers (and stack is getting features which also support this, e.g. as arguments to ls dependencies). It may be good for the templates to use the SPDX equivalent (BSD-3-Clause) instead.

@dbaynard
Copy link
Author

dbaynard commented Dec 3, 2018

(I'm happy to PR if desired; it's a simple grep)

@BinderDavid
Copy link

+1

This also requires to update the cabal-versions in the templates to at least 2.2. Otherwise the following warning will be emitted:

Warning: 'license: BSD-3' is not a recognised license. The known licenses are:                                                        
GPL, GPL-2, GPL-3, LGPL, LGPL-2.1, LGPL-3, AGPL, AGPL-3, BSD2, BSD3, MIT, ISC,                                                        
MPL-2.0, Apache, Apache-2.0, PublicDomain, AllRightsReserved, OtherLicense

An update would remove a little bit of friction that one encounters when trying to update the cabal version to 2.2. in order to use e.g. cabal common stanzas. In that case cabal complains about non SPDX compliant Licence specifiers.

@mpilgrem
Copy link
Member

If the BSD3 are replaced by BSD-3-Clause then Stack's in-built Hpack will specify cabal-version: 2.2. I think Cabal-2.2.0.0 was released in March 2018 and included with GHC 8.4.1 (also released in March 2018). Only resolvers before lts-12.1 are pre-GHC 8.4.1. I can't see any harm in bumping to BSD-3-Clause and, consequently, cabal-version: 2.2.

mpilgrem added a commit that referenced this issue Oct 1, 2023
Fix #136 Use SPDX licence descriptors
@mpilgrem
Copy link
Member

mpilgrem commented Oct 1, 2023

With no objections and the passage of another year, I have put this through. Stack still supports users of GHC < 8.4.1, but the number of such people inconvenienced by this is likely small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants