Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servant testing #65

Closed
wants to merge 1 commit into from
Closed

Conversation

algas
Copy link
Contributor

@algas algas commented May 27, 2016

Add hspec testing for servant

@decentral1se
Copy link
Member

decentral1se commented Feb 8, 2017

Hmmmm, I don't think everyone uses Hspec. This change is not generic enough. People who are using Tasty would have to remove this stuff. Thanks though 👍

@bitemyapp
Copy link
Contributor

@lwm I'm a bit vexed, you want to include more content in the repository but you rejected something that would've been almost strictly helpful for people starting out with Servant. Not everyone uses Hspec but most Haskellers I know do use Hspec. There were no tests for this scaffold prior to this PR.

@bitemyapp bitemyapp reopened this Feb 9, 2017
@decentral1se
Copy link
Member

decentral1se commented Feb 10, 2017

@bitemyapp, righto, merged that there, thanks for reviewing. Closed this one off a little hastily it seems. I see a lot of the other templates have Hspec setup as well. Apologies @algas and thanks for contributing.

@bitemyapp
Copy link
Contributor

@lwm how are you merging these? I usually prefer to use the merge button on the PRs so that attribution is solely to the author and so there's a revert button if someone needs it.

@decentral1se
Copy link
Member

@bitemyapp on the command line. The git log shows sole attribution, it's only the Github UI that does the 'with X' stuff. Can big green button from now on if you would prefer.

@algas
Copy link
Contributor Author

algas commented Feb 13, 2017

Thanks @bitemyapp and @lwm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants