Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stack warning about missing other-modules into an error (with flags) #1323

Open
ndmitchell opened this issue Nov 9, 2015 · 5 comments

Comments

@ndmitchell
Copy link
Contributor

If I run stack build it says:

Warning: modules not listed in shake.cabal for 'shake' component (add to other-modules):
    Development.Ninja.Env

How can I turn that into an error so I can test for it in my continuous integration? stack build --Werror? Add a separate stack check target?

@mgsloan
Copy link
Contributor

mgsloan commented Nov 10, 2015

One option would be to extend the meaning of --pedantic to also turn warnings like this into errors (only for things that are always resolvable).

@mgsloan mgsloan added this to the P3: Optional milestone Nov 10, 2015
@ndmitchell
Copy link
Contributor Author

I am happy to run with --Werror but my code is not --Wall clean, and I consider several of the Wall warnings to be actively harmful to code. Perhaps Stack should support both flags separately, as well as together with pedantic, then just Werror would have this effect.

@rvion
Copy link
Contributor

rvion commented Nov 10, 2015

I love this new flag idea, and also agree that not all Wall warnings should become errors with this flag

@borsboom
Copy link
Contributor

If anyone wants to work on a PR, that would be welcome.

@TheWizardTower
Copy link
Collaborator

This looks like a fun nugget to chew on. I'll tackle this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants