Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange leading newlines when logging build progress #2418

Closed
istathar opened this issue Jul 28, 2016 · 2 comments
Closed

Strange leading newlines when logging build progress #2418

istathar opened this issue Jul 28, 2016 · 2 comments
Assignees
@Blaisorblade

Comments

@istathar
Copy link
Contributor

For some reason, every time a configure step is logged, [13 spaces (?) and a] newline is preceding it. Was that on purpose?

...

quickcheck-io-0.1.3: configure
quickcheck-io-0.1.3: build
quickcheck-io-0.1.3: copy/register

hspec-core-2.2.3: configure
hspec-core-2.2.3: build
zlib-0.6.1.1: copy/register

zlib-bindings-0.1.1.5: configure
zlib-bindings-0.1.1.5: build
zlib-bindings-0.1.1.5: copy/register
hspec-core-2.2.3: copy/register

hspec-2.2.3: configure
hspec-2.2.3: build
hspec-2.2.3: copy/register
...

Not a problem, of course, just a surprise.
@istathar
Copy link
Contributor Author

istathar commented Aug 5, 2016

Employed git bisect and determined breaking change introduced in 6af46db.

istathar referenced this issue Aug 5, 2016
@Blaisorblade
stack unpack: Ignore pax headers (fix #2361)
6af46db 
* Stop trying to reset permissions on pax header entries.
* Add changelog entry.
* Output warnings for unexpected entries.
* Add testcases.

The interface of untar is designed for unit testing.
@istathar
Copy link
Contributor Author

istathar commented Aug 5, 2016

Referenced line has a

 $logWarn $ mconcat $ map (\(path, entryType) -> "Unexpected entry type " <> ...

thing going on. I'm guessing the result of there not being an "unexpected" condition is $logWarn being called with an empty string, resulting in our spurious newlines.

@istathar istathar mentioned this issue Aug 5, 2016
Merged
@Blaisorblade Blaisorblade self-assigned this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blaisorblade Blaisorblade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Blaisorblade @istathar