Fix make build-docker-local #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a couple problems with the Dockerfile which was resulting in a failed build. The likely culprit of this not being caught earlier was some cached images. This does two things 1. It removes unnecessary references to things that aren't being used any more. The ENV setting was removed in a previous commit, but not the reference of it later in the Dockerfile. If this is in error please let me know! 2. The go modules are cached in a layer as these are much less likely to change between build runs than the source code itself. The technique is simple enough; just copy the files in a separate COPY and run `go mod download`. This reduces the hydrated build time (previous layers cached) from 2m35s on average (3 runs) to 34s on average (3 runs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a couple problems with the Dockerfile which was
resulting in a failed build. The likely culprit of this not being caught
earlier was some cached images. This does two things
any more. The ENV setting was removed in a previous commit, but not the
reference of it later in the Dockerfile. If this is in error please let
me know!
change between build runs than the source code itself. The technique is
simple enough; just copy the files in a separate COPY and run
go mod download. This reduces the hydrated build time (previous layers cached)from 2m35s on average (3 runs) to 34s on average (3 runs).