version and build sha injected at link time into binary #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less self explanatory.
Instead of using the
updateVersion.shscript which would search and replace code we'd have to merge, we can have a separate system of versions and build IDs. Both of which can be retrieved at runtime by runningcommit0 version.We use the HEAD SHA of the git commit we're on so we can trace the commit that produced the binary. Version is human readable / process based so we have to figure that whole thing out.
We should probably also tag our docker images with the
commit0:${sha}as well but I can do that separately.