support module-config default / value #154
Conversation
davidcheung
commented
Jun 9, 2020
davidcheung
commented
- also adding support for project conditional prompts
internal/context/init.go
Outdated
| exit.Fatal("Prompt failed %v\n", err) | ||
| func getProjectPrompts(projectName string) map[string]PromptHandler { | ||
| return map[string]PromptHandler{ | ||
| "projectName": { |
There was a problem hiding this comment.
Since it was supplied on the command line we probably don't need to prompt for name. Or maybe we make it optional on the command line and then conditionally prompt here?
There was a problem hiding this comment.
#153 yeah we removed the projectName as a positional argument altogether just a little earlier, ill need to rebase with that change
| Label: "What's the root of the github org to create repositories in?", | ||
| Default: "github.com/", | ||
| }, | ||
| KeyMatchCondition("ShouldPushRepoUpstream", "y"), |
|
|
||
| projectConfig.Name = prompts["projectName"].GetParam(projectConfig.Parameters) | ||
|
|
||
| projectConfig.Parameters["ShouldPushRepoUpstream"] = prompts["ShouldPushRepoUpstream"].GetParam(projectConfig.Parameters) |
There was a problem hiding this comment.
You don't need to do this as part of this PR but shouldn't these be part of the projectConfig struct rather than parameters? Parameters are passed into project templates, but these values we will be using for zero itself during the create phase.
There was a problem hiding this comment.
I'll do this as part of my ticket.
| } | ||
|
|
||
| // TODO: validation / allow prompt retry ...etc | ||
| func (p PromptHandler) GetParam(projectParams map[string]string) string { |
There was a problem hiding this comment.
Seems like this would be a good one to have a test for, exercising the different types.
There was a problem hiding this comment.
i did, i aliased my git a to git add . -u and forgot to index the untracked file 😅 fixed now
davidcheung
force-pushed
the
prompt-default
branch
3 times, most recently
from
ad1f9a1
to
ef5cb76
Compare
- also adding support for project conditional prompts
davidcheung
force-pushed
the
prompt-default
branch
from
ef5cb76
to
544ab60
Compare
