ZER0155 update repo init to detect owner type #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
reviewed
Jun 12, 2020
internal/vcs/create-git-repos.go
Outdated
| // takes a list of subdirectories containing modules to create a repository and do initial commit for | ||
| func InitializeRepositories(moduleDirs []string, remoteRepository string, organizationName string, githubApiKey string) { | ||
| ownerName, repositoryName, pErr := parseRepositoryUrl(repositoryUrl) | ||
| if pErr != nil { |
There was a problem hiding this comment.
Any reason to not just have err and reuse it?
There was a problem hiding this comment.
I like to keep errors scoped as close to the call as possible, but its not really needed here. I can change this to reuse a single err.
bmonkman
reviewed
Jun 12, 2020
internal/vcs/create-git-repos.go
Outdated
| remoteOrigin := fmt.Sprintf("%s/%s.git", remoteRepository, moduleDir) | ||
| commands := []InitialCommands{ | ||
| remoteOrigin := fmt.Sprintf("git@github.com:%s/%s.git", ownerName, repositoryName) | ||
| fmt.Printf("remote origin: %s\n", remoteOrigin) |
There was a problem hiding this comment.
Probably not necessary to print
There was a problem hiding this comment.
Actually I think all the status prints in this probably aren't very useful to the user. Just one per repo saying we are creating a repo should be enough.
bmonkman
reviewed
Jun 12, 2020
internal/vcs/create-git-repos.go
Outdated
| ownerName := segments[1] | ||
| repositoryName := segments[2] | ||
|
|
||
| fmt.Printf("found owner %s, repository %s\n", ownerName, repositoryName) |
bmonkman
reviewed
Jun 12, 2020
internal/vcs/create-git-repos.go
Outdated
| return err | ||
| } | ||
|
|
||
| fmt.Printf("Repository successfully created for module: %s\n", repositoryName) |
There was a problem hiding this comment.
Just the above print should be enough
bmonkman
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.