Global cred prompt #164
Merged
Global cred prompt #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcheung
force-pushed
the
global-cred-prompt
branch
from
a9e32ff
to
d39cbcc
Compare
bmonkman
reviewed
Jun 16, 2020
| // FIXME: what is a good way to dynamically modify partial data of a struct | ||
| // current just marashing to yaml, then unmarshaling into the base struct | ||
| yamlContent, _ := yaml.Marshal(promptsValues) | ||
| yaml.Unmarshal(yamlContent, &credentials) |
There was a problem hiding this comment.
Probably okay for now though..
bmonkman
reviewed
Jun 16, 2020
internal/context/prompts.go
Outdated
| yamlContent, _ := yaml.Marshal(promptsValues) | ||
| yaml.Unmarshal(yamlContent, &credentials) | ||
|
|
||
| globalconfig.Save(credentials) |
There was a problem hiding this comment.
The name of this function doesn't make it very clear that it's actually going to save the file. Maybe rename or just return the credentials and let the caller save it?
davidcheung
force-pushed
the
global-cred-prompt
branch
from
6f1750d
to
dea7ac1
Compare
bmonkman
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.