-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create command #167
Merged
Merged
Add create command #167
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9df662d
Add create command, start refactoring generate code, add module sourc…
bmonkman 2321b10
Removed extra prints, fixed test, hooked up generator code
bmonkman 827cb9e
More cleanup
bmonkman b273fe1
Fix path checking in create
bmonkman 1a1ce93
Added test for generate
bmonkman File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package cmd | ||
|
||
import ( | ||
"fmt" | ||
"path" | ||
"strings" | ||
|
||
"github.com/commitdev/zero/internal/config/projectconfig" | ||
"github.com/commitdev/zero/internal/constants" | ||
"github.com/commitdev/zero/internal/generate" | ||
"github.com/commitdev/zero/pkg/util/exit" | ||
"github.com/spf13/cobra" | ||
) | ||
|
||
var createConfigPath string | ||
|
||
func init() { | ||
createCmd.PersistentFlags().StringVarP(&createConfigPath, "config", "c", constants.ZeroProjectYml, "config path") | ||
|
||
rootCmd.AddCommand(createCmd) | ||
} | ||
|
||
var createCmd = &cobra.Command{ | ||
Use: "create", | ||
Short: fmt.Sprintf("Create projects for modules and configuration specified in %s", constants.ZeroProjectYml), | ||
Run: func(cmd *cobra.Command, args []string) { | ||
Create(projectconfig.RootDir, createConfigPath) | ||
}, | ||
} | ||
|
||
func Create(dir string, createConfigPath string) { | ||
if strings.Trim(createConfigPath, " ") == "" { | ||
exit.Fatal("config path cannot be empty!") | ||
} | ||
configFilePath := path.Join(dir, createConfigPath) | ||
projectConfig := projectconfig.LoadConfig(configFilePath) | ||
|
||
generate.Generate(*projectConfig) | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it bad to just add source to the moduleConfig itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModuleConfig represents the structure of the module file, so we don't want it in there.