vendor credentials is env-vars for execute #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
reviewed
Jun 24, 2020
| } | ||
| } | ||
| return list | ||
| } | ||
|
|
||
| func (p ProjectCredential) SelectedVendorsCredentialsAsEnv(vendors []string) map[string]string { |
There was a problem hiding this comment.
Mind adding this to Apply as well?
Right now it's just loading all creds but I guess it would be nice to be more precise and only expose the necessary ones.
You'll need to load the module config to be able to get the required creds first though.
davidcheung
force-pushed
the
credentials-in-execute
branch
5 times, most recently
from
12b9802
to
112779b
Compare
bmonkman
approved these changes
Jun 25, 2020
|
Hey @davidcheung , which command (init, apply etc..) is this ticket for? |
davidcheung
force-pushed
the
credentials-in-execute
branch
from
112779b
to
767af71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.