New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initial react generator #26
Conversation
Overall:
Planned next:
|
@@ -0,0 +1,31 @@ | |||
{ | |||
"name": "{{ .Name }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
templating still works with real extensions
} | ||
} | ||
|
||
type DirectoryTemplator struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this provides a very generic templator that we can use for any directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense - but i don't think everywhere will be able to use it at-least in some of the backend pieces. So I don't think we could replace everything with this. Though the majority should be able to use this.
How would this work for bits where each file needs a bit of additional context like here https://github.com/commitdev/commit0/blob/f679a5cb7eedf23c3f08a612a65ba5b7f4fee9f2/generate/proto/generate.go#L69 ?
Also should this live in the util package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.