Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some dirs from root into internal, shuffle some stuff around in cmd #51

Merged
merged 1 commit into from Oct 24, 2019
Merged

Move some dirs from root into internal, shuffle some stuff around in cmd #51

merged 1 commit into from Oct 24, 2019

Conversation

bmonkman
Copy link
Member

No description provided.

jb55
jb55 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice, this is much better. the global was a bit weird. although now we do have packr.New/NewTemplator construction duplicated in a bunch of places, perhaps we could create a helper default Templator constructor in a future PR.

@bmonkman bmonkman merged commit ba409d9 into master Oct 24, 2019
@bmonkman bmonkman deleted the restructure-project branch October 24, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@kb-commit kb-commit kb-commit approved these changes

@Pritesh-Patel Pritesh-Patel Awaiting requested review from Pritesh-Patel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmonkman @jb55 @kb-commit