Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes #71

Merged
merged 11 commits into from Nov 10, 2019
Merged

Kubernetes #71

merged 11 commits into from Nov 10, 2019

Conversation

ShahNewazKhan
Copy link
Contributor

  • Added support to get aws creds from prompt if config.kubernetes.deploy = true
  • Resolved x509 cacert issue for docker

#66

bmonkman
bmonkman reviewed Nov 9, 2019
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
bmonkman
bmonkman reviewed Nov 9, 2019
View reviewed changes
go.sum
@@ -1,5 +1,18 @@
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
github.com/alecthomas/gometalinter v2.0.11+incompatible h1:ENdXMllZNSVDTJUUVIzBW9CSEpntTrQa76iRsEFLX/M=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did all these new deps come from the prompt lib?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct https://github.com/manifoldco/promptui/blob/master/go.mod#L4

@ShahNewazKhan
Copy link
Contributor Author

@bmonkman updated as per review comments

Shah Newaz Khan added 11 commits November 9, 2019 16:41
@ShahNewazKhan ShahNewazKhan merged commit 1879690 into master Nov 10, 2019
@ShahNewazKhan ShahNewazKhan deleted the kubernetes branch November 10, 2019 01:14
@ShahNewazKhan ShahNewazKhan mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmonkman bmonkman bmonkman approved these changes

@benjaminkvm benjaminkvm Awaiting requested review from benjaminkvm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShahNewazKhan @bmonkman