Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new react templates, github CI and terraform generators #72

Merged
merged 6 commits into from Nov 10, 2019

Conversation

zthomas
Copy link
Contributor

@zthomas zthomas commented Nov 9, 2019

No description provided.

uses: actions/upload-artifact@v1
with:
name: build
path: build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important now but you should make sure you have "add newline at end of file" turned in in your editor.

@zthomas zthomas marked this pull request as ready for review November 10, 2019 00:53
@zthomas zthomas changed the title added new react templates with ejs delimiter added new react templates, github CI and terraform generators Nov 10, 2019
@bmonkman
Copy link
Member

bmonkman commented Nov 10, 2019

Feel free to just merge actually, I'll fix the tf when I rebase

@bmonkman bmonkman closed this Nov 10, 2019
@bmonkman bmonkman reopened this Nov 10, 2019
Copy link
Contributor

@ShahNewazKhan ShahNewazKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zthomas zthomas merged commit c0e62fd into master Nov 10, 2019
@zthomas zthomas deleted the react-templates branch November 10, 2019 02:29
Copy link
Contributor

@ShahNewazKhan ShahNewazKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to resolve the conflicts from master as Execute() params and functionality has changed upstream

Wrong pr 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants