-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated terraform outputs in frontend code-gen #75
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f35c86b
updated frontend templates
8b32944
updated readme and configs
8ebec4d
added react environment configs
1a2ba87
merged master
03db618
updated frontend generated code with env vars
27e302f
added cleanups and fixed typo
46c0ac0
removed redundant remote state configs
7f49280
refactored cognito terraform and generators
550b09e
moved user pool config out of defaults into environment specific inpu…
4e0f856
added s3 hosting module and organized terraform
a9d7d51
removed default value for hostname
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,19 @@ func GenerateArtifactsHelper(t *templator.Templator, cfg *config.Commit0Config, | |
kubernetes.Generate(t, cfg, &wg, pathPrefix) | ||
} | ||
|
||
log.Println(aurora.Cyan(emoji.Sprintf("Generating Terraform"))) | ||
terraform.Generate(t, cfg, &wg, pathPrefix) | ||
if cfg.Infrastructure.AWS.Cognito.Deploy { | ||
|
||
outputs := []string{ | ||
"cognito_pool_id", | ||
"cognito_client_id", | ||
} | ||
outputValues := terraform.ExecuteWithOuput(cfg, pathPrefix, outputs) | ||
cfg.Frontend.Env.CognitoPoolID = outputValues["cognito_pool_id"] | ||
cfg.Frontend.Env.CognitoClientID = outputValues["cognito_client_id"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should write these values back to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yup for sure, I think we definitely should do that |
||
} | ||
|
||
// @TODO : This strucuture probably needs to be adjusted. Probably too generic. | ||
switch cfg.Frontend.Framework { | ||
case util.React: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary solution. We'll need to figure out a system to the scenarios where one part of the code generation requires some output from another step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah, that's gonna get complicated..