Added prompts at project create, including lookups for aws credential… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zthomas
approved these changes
Nov 13, 2019
|
|
||
| defaultProjConfig := defaultProjConfig(projectName) | ||
|
|
||
| defaultProjConfig.Infrastructure.AWS.Region = regionResult | ||
| if awsCaller != nil && awsCaller.Account != nil { | ||
| defaultProjConfig.Infrastructure.AWS.AccountID = *awsCaller.Account |
zthomas
reviewed
Nov 13, 2019
| @@ -22,16 +29,63 @@ func Create(projectName string, outDir string, t *templator.Templator) string { | |||
| rootDir := path.Join(outDir, projectName) | |||
| log.Println(aurora.Cyan(emoji.Sprintf(":tada: Creating project %s.", projectName))) | |||
| err := os.MkdirAll(rootDir, os.ModePerm) | |||
|
|
|||
There was a problem hiding this comment.
The command handlers should be kept slim and we should try to move all the logic deeper into some logical models. Love to plan out a clearer architecture for this project on Friday.
There was a problem hiding this comment.
Yeah I left a todo there
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| // @TODO : Figure out a way to test this |
There was a problem hiding this comment.
Shane has some ci integration tests to check if the templates populated under /tests
There was a problem hiding this comment.
Yeah, this test needs to be moved to a different level now because now this function triggers prompts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and account id