Skip to content

Commit

Permalink
test(test_git): get_tag_names should have List[Optional[str]] annotation
Browse files Browse the repository at this point in the history
issue #285
  • Loading branch information
christian-hawk committed Oct 25, 2020
1 parent 2a94361 commit a62354f
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tests/test_git.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import inspect
from typing import List, Optional, Union

import pytest

from commitizen import git
Expand Down Expand Up @@ -68,3 +71,9 @@ def test_get_commits_author_and_email():

assert commit.author is not ""
assert "@" in commit.author_email


def test_get_tag_names_has_correct_arrow_annotation():
arrow_annotation = inspect.getfullargspec(git.get_tag_names).annotations["return"]

assert arrow_annotation == List[Optional[str]]

0 comments on commit a62354f

Please sign in to comment.