Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RyeProvider to version providers. #1102

Closed
tabassco opened this issue May 12, 2024 · 4 comments
Closed

Add RyeProvider to version providers. #1102

tabassco opened this issue May 12, 2024 · 4 comments

Comments

@tabassco
Copy link

Description

I'd like to support Rye (https://rye-up.com) to provide versioning.
It should be a simple addition as it utilizes the same pyproject.toml as poetry, etc.

I'll gladly implement this.

Possible Solution

Add RyeProvider class in providers module

Additional context

No response

Additional context

No response

@Lee-W
Copy link
Member

Lee-W commented May 13, 2024

Hi @tabassco , thanks for creating this issue. But we'd like to avoid adding new providers to the core. We'd encourage to create your own provider plugin and we'll be more than happy to mention your plugin in https://commitizen-tools.github.io/commitizen/third-party-commitizen/#installation_3. (This page should probably be updated a bit, though 🤔 )

@Lee-W Lee-W closed this as completed May 13, 2024
@woile
Copy link
Member

woile commented May 13, 2024

If my memory serves me well, rye uses the default parameters from [project], so the pep621 should work with rye for version management.
https://commitizen-tools.github.io/commitizen/config/#version-providers

@Lee-W
Copy link
Member

Lee-W commented May 13, 2024

@woile Looks like some of the detail is still different 🤔 https://github.com/commitizen-tools/commitizen/pull/1103/files

@woile
Copy link
Member

woile commented May 13, 2024

I haven't found any rye repo using that configuration, even the default template from rye uses version from the [project]:
https://github.com/astral-sh/rye/blob/main/rye/src/templates/pyproject.toml.j2#L3

On top of that, running rye version -b minor also bumps the [project.version], not the tool.rye.version. I think the tool.rye.version points to the actual version of rye that you expect in the project (I couldn't find any docs about it though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants