Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): add rye version provider #1103

Closed

Conversation

tabassco
Copy link

Description

I added a Rye Version provider. Tests are also added, analogue to the poetry version provider. (Where I took the liberty to rename the test function from a previous copy paste)

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Using RyeProvider allows to also manage version when using Rye as a local dev env.

Additional context

Closes #1102

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (120d514) to head (7fd218f).
Report is 311 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
+ Coverage   97.33%   97.55%   +0.21%     
==========================================
  Files          42       56      +14     
  Lines        2104     2496     +392     
==========================================
+ Hits         2048     2435     +387     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.55% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W
Copy link
Member

Lee-W commented May 13, 2024

Hi @tabassco , thank you for contributing, but we'd like to avoid adding new providers to the core. Please check #1102 (comment)

@Lee-W Lee-W closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RyeProvider to version providers.
2 participants