Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands/bump): Add NoneIncrementExit to avoid git fatal error #284

Merged
merged 6 commits into from
Oct 26, 2020

Conversation

christian-hawk
Copy link
Contributor

@christian-hawk christian-hawk commented Oct 25, 2020

… creating existing tag

raises NoneIncrementExit if increment is None and new_tag_version == current_tag_version

closes #280

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Not raising git fatal error (please see #280 )

Steps to Test This Pull Request

  1. commit a test, ci, build or doc w/ cz c
  2. run cz bump
  3. no fatal error will occur

… creating existing tag

raises NoneIncrementExit if `increment is None and new_tag_version == current_tag_version`

commitizen-tools#280
@christian-hawk
Copy link
Contributor Author

Opened issue related to github action test errors: #285

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #284 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   96.62%   96.64%   +0.01%     
==========================================
  Files          33       33              
  Lines         919      923       +4     
==========================================
+ Hits          888      892       +4     
  Misses         31       31              
Flag Coverage Δ
#unittests 96.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/commands/init.py 91.30% <ø> (ø)
commitizen/commands/bump.py 90.80% <100.00%> (+0.21%) ⬆️
commitizen/git.py 95.55% <100.00%> (+0.04%) ⬆️
commitizen/cz/base.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0dd54...6370be0. Read the comment docs.

@christian-hawk
Copy link
Contributor Author

christian-hawk commented Oct 25, 2020

closes #285

mypy fixed

@woile woile merged commit 4b7c175 into commitizen-tools:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commitizen tries to create a tag eventhough no increment is detected and it fails with tag already exists.
2 participants