Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort if no change #49

Merged
merged 4 commits into from
Nov 9, 2019
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 9, 2019

#45

@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #49 into master will decrease coverage by 4.94%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #49      +/-   ##
=========================================
- Coverage   93.05%   88.1%   -4.95%     
=========================================
  Files          24      24              
  Lines         547     555       +8     
=========================================
- Hits          509     489      -20     
- Misses         38      66      +28
Impacted Files Coverage Δ
commitizen/git.py 100% <100%> (ø) ⬆️
commitizen/commands/commit.py 40.42% <100%> (-52.6%) ⬇️
commitizen/out.py 86.66% <0%> (-13.34%) ⬇️
commitizen/cz/base.py 95.83% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6ffb0...373ec25. Read the comment docs.

@woile
Copy link
Member

woile commented Nov 9, 2019

Fine by me, if eventually someone needs --alow-empty we can consider it.

@woile woile merged commit 0637a6b into commitizen-tools:master Nov 9, 2019
@Lee-W Lee-W deleted the abort-if-no-change branch December 18, 2019 08:42
@alecgerona
Copy link
Contributor

@woile I think the time has come. I think we need to respect the --allow-empty flag.

@woile
Copy link
Member

woile commented Aug 13, 2020

Hahahah 😱
Please create a ticket describing the problem and proposed solution (sorry for the burocracy but otherwise we will forget 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants