Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert Travis to GitHub Actions #183

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Dec 3, 2021

The publish could probably be replaced with https://github.com/cycjimmy/semantic-release-action, but would require the GitHub secrets to be configures so I skipped it for now. Mostly copied over from https://github.com/htmlhint/HTMLHint, where the semantic release part is used

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2021

Demo run is https://github.com/nschonni/cz-conventional-changelog/runs/4403067285?check_suite_focus=true but is currently failing on all platforms.

  1) commitlint config header-max-length
       with no environment or commitizen config override:
     TypeError: explore is not a function
      at Z:\cz-conventional-changelog\node_modules\@commitlint\load\lib\index.js:158:26
      at new Promise (<anonymous>)
      at loadConfig (node_modules\@commitlint\load\lib\index.js:152:9)
      at Object.<anonymous> (node_modules\@commitlint\load\lib\index.js:44:25)
      at new Promise (<anonymous>)
      at exports.default (node_modules\@commitlint\load\lib\index.js:42:68)
      at mockOptions (engine.test.js:431:41)
      at Context.<anonymous> (engine.test.js:448:14)
      at processImmediate (node:internal/timers:464:21)

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2021

Seems like

"@commitlint/load": ">6.1.1"
needs to be pinned to just ^6.1.1 since newer versions have a few different breaks depending on which newer one NPM decides to peer install.

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2021

With 9+, the error becomes

  1) commitlint config header-max-length
       with no environment or commitizen config override:

      AssertionError: expected { Object (types, defaultType, ...) } to have property 'maxHeaderWidth' of 72, but got 100
      + expected - actual

      -100
      +72

      at Z:\cz-conventional-changelog\engine.test.js:449:33
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

@dmwelch dmwelch merged commit a93bd96 into commitizen:master Sep 20, 2022
@nschonni nschonni deleted the github-actions branch September 20, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants