Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(require): get rid of relative path to the word-wrap #5

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

Den-dp
Copy link
Contributor

@Den-dp Den-dp commented Sep 17, 2015

Fix this module for npm@3 where flat directory structure is "by default". A bit of background: If the module identifier passed to require() is not a native module, and does not begin with '/', '../', or './', then Node.js starts at the parent directory of the current module, and adds /node_modules, and attempts to load the module from that location. If it is not found there, then it moves to the parent directory, and so on, until the root of the file system is reached.

This closes #4

Fix this module for npm@3 where flat directory structure is "by default". A bit of background: If the module identifier passed to require() is not a native module, and does not begin with '/', '../', or './', then Node.js starts at the parent directory of the current module, and adds /node_modules, and attempts to load the module from that location. If it is not found there, then it moves to the parent directory, and so on, until the root of the file system is reached.

This closes commitizen#4
jimthedev added a commit that referenced this pull request Sep 17, 2015
fix(require): get rid of relative path to the word-wrap
@jimthedev jimthedev merged commit 6f66e02 into commitizen:master Sep 17, 2015
@jimthedev
Copy link
Member

Thanks, I'll cut a release with this shortly.

@shairez
Copy link

shairez commented Sep 23, 2015

Can you please republish it to npm as the latest? (I'm still getting the old relative word-wrap version)

Thanks!

@jimthedev
Copy link
Member

@shairez Thanks. 1.1.1 has been released to npm. Can you try it again?

@shairez
Copy link

shairez commented Sep 23, 2015

Checked, still get an error

I'm running on Windows,
Node v4.1.1
Npm v3.3.3

Get the following error:
Error loading "word-wrap" at file..:/node_modules/cz-conventional-changelog/word-wrap.js

@jimthedev
Copy link
Member

Thanks. I'll look into it.
On Wed, Sep 23, 2015 at 10:49 AM Shai Reznik notifications@github.com
wrote:

Checked, still get an error

I'm running on Windows,
Node v4.1.1
Npm v3.3.3

Get the following error:
Error loading "word-wrap" at
file..:/node_modules/cz-conventional-changelog/word-wrap.js


Reply to this email directly or view it on GitHub
#5 (comment)
.

@jimthedev
Copy link
Member

@rodrigo-medeiros @shairez @Den-dp, I am having to roll back this PR for 1.1.2 and will be rewriting the cli and adapters for npm3 and node4. Since the core assumptions of where things are located have changed, it will probably introduce breaking changes and thus new npm and new node will be a 2.0.0 feature. I am already working on it but I wanted to make sure to give an update in this PR since it introduced some breaking changes for older node versions.

@shairez
Copy link

shairez commented Sep 28, 2015

Thanks @jimthedev for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please consider the case with new npm and flat dependencies
4 participants