-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #205 - Update to callback - Inquirer interface requires Promise #3
Conversation
Link to issue since it's actually in another repo. |
Please @jimthedev merge this. update: oh the tests... Could you @zacharytelschow update the tests ? |
@janecakemaster originally wrote the tests, I wonder if she'd be willing to help. Also we need to get a working travis config. |
@jimthedev which test are we talking about? sry it's been a while since I've touched this 😁 |
@janecakemaster haha no worries. Basically @zacharytelschow made some changes in his fork that break the tests you previously wrote. He is afk for right now but if you run the following you'll see the tests that are failing:
|
I think that we should add inquirer as a dependency and require it ourselves, as discussed here: commitizen/cz-cli#249 This will prevent this from happening again :) If we merge this as is, it will break for people using an older cz-cli (which they presumable are using since updating breaks...) |
But do not merge it means unusable for every new comer that just install last cz-cli (my case). |
Yes, this would be a breaking change. We'd go to 2.0. Jim ForCy On July 22, 2016 at 5:03:03 AM, Jean-Michel FRANCOIS (
|
@zacharytelschow |
This will not be a breaking change if we require and use our own version of inquirer |
I appreciate that you all care about fixing this the right way. But in the meantime, people depend on this package and it has been unusable for some time with the current version of commitizen. |
…ity w/current commitizen.
@bgannonPL the correct fix is here 🎉 -> #5 |
Resolved with #5 |
@jimthedev: I realize the irony of not using one of your commit adapters to submit a pull request, but I didn't see contribution guidelines in your README 😄 I have tested this change on my local and it works. Please let me know if there are any further changes you'd like to see.