Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker build to latest version/automate builds #92

Closed
D-Nice opened this issue Sep 6, 2019 · 4 comments · Fixed by #100
Closed

update docker build to latest version/automate builds #92

D-Nice opened this issue Sep 6, 2019 · 4 comments · Fixed by #100
Labels
bug Something isn't working

Comments

@D-Nice
Copy link

D-Nice commented Sep 6, 2019

Just tried this tool, and ran into the issue where merge commits are being identified as non-compliant, but it seems this was fixed a few days ago. Since I'm using docker, would be useful to have that build updated, or better yet so it's automated :).

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.86. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@fallion
Copy link
Member

fallion commented Sep 10, 2019

@D-Nice this should be released now.

@fallion
Copy link
Member

fallion commented Sep 10, 2019

I checked out the failing pipeline you had. Some weird voodoo going on.

According to Dockerhub latest should be up to date https://cloud.docker.com/u/commitsar/repository/docker/commitsar/commitsar

Can you try pinning 0.6.3 or using the Github action?

@fallion
Copy link
Member

fallion commented Sep 10, 2019

Actually upon further investigation I found that the commit in question is failing the regex for merge commit identification. D-Nice/solinfra-homepage@8aee97a

I will fix it tomorrow and publish a new version.

@fallion fallion added the bug Something isn't working label Sep 10, 2019
fallion added a commit that referenced this issue Sep 11, 2019
- Github PR format was not covered by the regexes

Closes #92
fallion added a commit that referenced this issue Sep 11, 2019
- Github PR format was not covered by the regexes

Closes #92
fallion added a commit that referenced this issue Sep 11, 2019
- Github PR format was not covered by the regexes

Closes #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants