Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File keychain backend should bail in credential process rather than hanging #637

Open
chrnorm opened this issue Apr 17, 2024 · 1 comment

Comments

@chrnorm
Copy link
Contributor

chrnorm commented Apr 17, 2024

Reported by Gautam in our community Slack and related to #610.

granted credential-process hangs waiting for input on unlocking the credential file. The solution proposed in #610 is to install pass, but Gautam is using a shared machine and it isn't desirable to force everyone to use pass.

Rather than prompting for user input we should bail if the credential file password is unset.

This will likely involve setting PromptFunc in the keychain config struct to return an error when used with the credential_process integration.

@gautamg795
Copy link
Contributor

Rather than prompting for user input we should bail if the credential file password is unset.

FWIW, I think the behavior while this "worked" for me wasn't to bail, but to just proceed by using an empty password? I'm actually not totally sure; I might not have ever utilized the credential helper explicitly by passing a --profile to the AWS CLI that was different than the assumed profile.
But the behavior right now is that I can't use any AWS commands while credential_helper is set up for a profile without hanging (Ctrl-C / Ctrl-\ doesn't work — only kill from a different TTY).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants