Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another way to fix Issue #2253 #2915

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

ubaidisaev
Copy link
Contributor

before
after

@phirework
Copy link
Contributor

Hi there, I'm not able to replicate that old UI bug anymore on the current version of CV, can you tell me what your steps to reproduce were and what your browser/OS/screen size specs are? https://commonvoice.mozilla.org/

@ubaidisaev
Copy link
Contributor Author

Hi there, I'm not able to replicate that old UI bug anymore on the current version of CV, can you tell me what your steps to reproduce were and what your browser/OS/screen size specs are? https://commonvoice.mozilla.org/

Hi. In resolution ~ 2000px and higher.
Winddow 10
Chrome-86
firefox-82

@phirework
Copy link
Contributor

Gotcha. Instead of adding custom LTR/RTL rules I would actually prefer to refactor the column setup of the profile view to not rely on --var(--wide-desktop-width) for positioning. Is that something you'd feel comfortable taking on? You'd need to look at layout.tsx as well.

@ubaidisaev
Copy link
Contributor Author

Fixed without relying on LTR/RTL rules.

@phirework
Copy link
Contributor

Perfect, thank you!

@phirework phirework merged commit 2b7b557 into common-voice:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants