-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution page fix #3006
Contribution page fix #3006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for your patience! Most of this looks fine, but when the page is in LTR the labels are squished together. Can you take another look and ensure it works in both directions?
Sorry @phirework, but could you please let me know what LTR is? Is it Left-to-Right written language? |
Yep, that's correct! You can change the Common Voice language to something Arabic to see it organically, but during development you can use the inspector tool of whatever browser you're using to modify the |
Do you mean RTL here ? e.g. Arabic is |
@ftyers, I had the same doubt, but I have tested it for RTL; here is the screenshot. The labels were not squished together; please have a look. Feedbacks are most welcomed. Thank you! |
Yep sorry, I misspoke. Weird, I can't seem to reproduce it anymore, my bad. Congrats on your first PR! |
As mentioned in issue #2880 , the components of "Contribution Activity" and "Top Contributors" were misaligned. I've fixed those cards. If there is any feedback or still any error, please feel free to provide it.