Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution page fix #3006

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

Dnouv
Copy link
Contributor

@Dnouv Dnouv commented Feb 8, 2021

As mentioned in issue #2880 , the components of "Contribution Activity" and "Top Contributors" were misaligned. I've fixed those cards. If there is any feedback or still any error, please feel free to provide it.

@Dnouv
Copy link
Contributor Author

Dnouv commented Feb 10, 2021

Apologies,
I forgot to put the screenshots of the updated pages. Here are both old and fixed page screenshots.
common-voice_web
This one is the page with the issue.

c-v_fixed

This is the fixed page screenshot.

Please feel free to provide feedback. I hope the changes can now be compared.
Thank you!

@phirework phirework self-requested a review March 22, 2021 23:28
Copy link
Contributor

@phirework phirework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your patience! Most of this looks fine, but when the page is in LTR the labels are squished together. Can you take another look and ensure it works in both directions?

@Dnouv
Copy link
Contributor Author

Dnouv commented Mar 23, 2021

Sorry @phirework, but could you please let me know what LTR is? Is it Left-to-Right written language?

@phirework
Copy link
Contributor

Yep, that's correct! You can change the Common Voice language to something Arabic to see it organically, but during development you can use the inspector tool of whatever browser you're using to modify the dir attribute of the html element to ltr.

@ftyers
Copy link
Collaborator

ftyers commented Mar 26, 2021

Yep, that's correct! You can change the Common Voice language to something Arabic to see it organically, but during development you can use the inspector tool of whatever browser you're using to modify the dir attribute of the html element to ltr.

Do you mean RTL here ? e.g. Arabic is dir="rtl" i think, English is dir="ltr".

@Dnouv
Copy link
Contributor Author

Dnouv commented Mar 26, 2021

@ftyers, I had the same doubt, but I have tested it for RTL; here is the screenshot. The labels were not squished together; please have a look.
cb-page_fix

Feedbacks are most welcomed. Thank you!

@phirework
Copy link
Contributor

Yep sorry, I misspoke. Weird, I can't seem to reproduce it anymore, my bad. Congrats on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants