Implement new language variants #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcolleyz
reviewed
Feb 9, 2022
zcolleyz
reviewed
Feb 10, 2022
zcolleyz
reviewed
Feb 14, 2022
zcolleyz
reviewed
Feb 14, 2022
zcolleyz
reviewed
Feb 14, 2022
zcolleyz
reviewed
Feb 14, 2022
mozgzh
force-pushed
the
add-variant-language-data
branch
from
a0612e3
to
981a987
Compare
zcolleyz
reviewed
Feb 15, 2022
zcolleyz
reviewed
Feb 16, 2022
| @@ -437,6 +530,7 @@ const UserClient = { | |||
| updateDemographicsPromise, | |||
| this.claimContributions(clientId, clientIds), | |||
| languages && updateLanguages(clientId, languages), | |||
There was a problem hiding this comment.
Wondering here instead of adding another line for variants we rename updateLanguages to updateAccents and then add a function like:
/**
* Updates languages for a given user
*
* @param clientId clientId as string
* @param languages array of UserLanguage
* @returns void
*/
async function updateLanguages(clientId: string, languages: UserLanguage[]) {
return Promise.all([
updateAccents(clientId, languages),
updateVariants(clientId, languages),
]);
}
zcolleyz
reviewed
Feb 16, 2022
| @@ -0,0 +1,71 @@ | |||
| const VARIANTS = [ | |||
There was a problem hiding this comment.
Need to remove this test data
There was a problem hiding this comment.
Yeah, need to remove test data, but ill keep it for now, as itll be the basis of the import script once variants are decided
zcolleyz
changed the title
|
Pushed up an update for the label copy: 60acd5c |
@ftyers Good idea, I'll post it on the JIRA ticket so EM can give some input there too |
|
Going to merge this in dev to get some more eyes for QA |
zcolleyz
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Add migration for new variant table * Remove repeated data * Add initial variants query * Add GET route for variant * Format code * Add working variants query * Add types for variants * Add init user variant update logic * Refactor diff function and add unit tests * Update variant method to handle erroneous variant ids * Init user endpoint for variants * Update tslint * Simplify getdiff code * Simplify getdiff code * Clean up erroneous variables * Use newer type * Update variant type * Updat variant migrations * Refactor update endpoint for one variant per language * Remove early return * chore(languages): fix up current components * feat(variant): UI for new language variants * fix(api): placeholder api response for variants * chore(linting): please tslint * fix(accessibility): replace broken expandable info component * feat(variants): add help text when variant option present * Update user client queries * Remove extra accent check * Fix join when variants table empty * change comment * Update variant join to ensure it matches locale * Use variant api * Clean up log * feat(variant): update label for UI * Remove test data * Add variant data * Ensure user_clients variants are deleted if variant is also deleteD * Add variant data and import it Co-authored-by: g <g@pop-os.localdomain> Co-authored-by: Zac Colley <zac@mozillafoundation.org>
zcolleyz
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Add migration for new variant table * Remove repeated data * Add initial variants query * Add GET route for variant * Format code * Add working variants query * Add types for variants * Add init user variant update logic * Refactor diff function and add unit tests * Update variant method to handle erroneous variant ids * Init user endpoint for variants * Update tslint * Simplify getdiff code * Simplify getdiff code * Clean up erroneous variables * Use newer type * Update variant type * Updat variant migrations * Refactor update endpoint for one variant per language * Remove early return * chore(languages): fix up current components * feat(variant): UI for new language variants * fix(api): placeholder api response for variants * chore(linting): please tslint * fix(accessibility): replace broken expandable info component * feat(variants): add help text when variant option present * Update user client queries * Remove extra accent check * Fix join when variants table empty * change comment * Update variant join to ensure it matches locale * Use variant api * Clean up log * feat(variant): update label for UI * Remove test data * Add variant data * Ensure user_clients variants are deleted if variant is also deleteD * Add variant data and import it Co-authored-by: g <g@pop-os.localdomain> Co-authored-by: Zac Colley <zac@mozillafoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend
JIRA ticket: https://mozilla-hub.atlassian.net/browse/OI-2044
ExpandableInformationcomponent to replace broken component (profile-toggle)Backend
...
Database
Add two tables for variants
variantsholds the literally variant types and associated labelinguser_client_variantsholds the relation between a user and the variant