Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile): don't allow empty custom accents values #3478

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

zcolleyz
Copy link
Contributor

@zcolleyz zcolleyz commented Feb 23, 2022

This PR stops users from entering empty custom accents on the profile page when adding languages.

Thanks @mozgzh

@zcolleyz zcolleyz requested review from a team, phirework and mozgzh and removed request for a team February 23, 2022 10:30
Copy link
Contributor

@mozgzh mozgzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🚀

@zcolleyz zcolleyz merged commit d83d4d0 into main Feb 23, 2022
@zcolleyz zcolleyz deleted the fix-empty-accent-bug branch February 23, 2022 15:56
@phirework
Copy link
Contributor

Hey I have some concerns here - the reason empty accents were allowed was because:

  1. Prior to user-submitted accents being a feature, users who added languages to their profiles would often add language without an accent, and all of that legacy data needed to be migrated into the new system
  2. On the basis of data minimization, users should be allowed to determine what level of granularity of data they want to provide. And I'm concerned that disallowing empty entries (i.e. just a language with no accent) would either disincentivize adding languages altogether, or create noise with lots of people just writing "n/a" or irrelevant info, especially given how many speakers of dominant accents don't think of themselves as having an accent at all.

Is there a specific design/UX reason why you wanted to disable empty accents?

@zcolleyz
Copy link
Contributor Author

zcolleyz commented Feb 24, 2022

@phirework so this PR stops someone from entering something like '[ blank white space here ]' as a custom accent, you still don't have to set any accents if you don't want

@phirework
Copy link
Contributor

@zaccolley Cool, thanks!

@zcolleyz zcolleyz changed the title fix(profile): don't allow empty accents values fix(profile): don't allow empty custom accents values Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants