Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various problems on Datasets page #3515

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Fix various problems on Datasets page #3515

merged 5 commits into from
Mar 22, 2022

Conversation

zcolleyz
Copy link
Contributor

@zcolleyz zcolleyz commented Mar 14, 2022 •
edited

  • Correctly load datasets information on datasets page instead of embedding all of them into the main JavaScript bundle
  • Refactor datasets page components
  • Allow Spinner to be used inline in website for loading states
  • Add in an actual heading replacing the summary of page (Fixes Dataset page description: design is not l10n-friendly  #1877)
  • Simplify and remove datasets/dashboard pages from the demo
  • Fix and simplify backgrounds, various styling fixes

Changes in bundle size in KB Gzipped (with percentage change)

All Main Datasets Page
Before 322.8 269.96 5.4
After 245.32 (-24%) 181.21 (-39%) 12.24 (+127%)

image

@zcolleyz zcolleyz changed the title Fix datasets data in bundle fix(datasets-page): data in bundle Mar 14, 2022
@zcolleyz zcolleyz marked this pull request as ready for review March 14, 2022 13:41
@zcolleyz zcolleyz requested a review from a team as a code owner March 14, 2022 13:41
@zcolleyz zcolleyz requested review from mozgzh and removed request for a team March 14, 2022 13:41
@zcolleyz
Copy link
Contributor Author

I actually want to put some tests on these pages

@zcolleyz zcolleyz removed the request for review from mozgzh March 14, 2022 13:46
@zcolleyz zcolleyz added the Work In Progress Do not merge or review. Here for reference only. label Mar 14, 2022
@zcolleyz zcolleyz mentioned this pull request Mar 15, 2022
Closed
@zcolleyz zcolleyz force-pushed the fix-datasets-data-in-bundle branch from 3026d38 to 65e4144 Compare March 15, 2022 16:44
@zcolleyz zcolleyz changed the title fix(datasets-page): data in bundle Fix various problems on Datasets page Mar 15, 2022
mozgzh
mozgzh approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@mozgzh mozgzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks good, but because so much has changed its a little hard to keep track of. I'd recommend merging this for a separate deploy such that it'd be easier to test on dev/stage/prod.

@zcolleyz zcolleyz force-pushed the fix-datasets-data-in-bundle branch from 65e4144 to 3f09023 Compare March 16, 2022 13:25
@zcolleyz
Copy link
Contributor Author

I agree

@zcolleyz zcolleyz removed the Work In Progress Do not merge or review. Here for reference only. label Mar 21, 2022
@zcolleyz zcolleyz force-pushed the fix-datasets-data-in-bundle branch 2 times, most recently from 25a672b to 489096c Compare March 21, 2022 14:40
@zcolleyz zcolleyz force-pushed the fix-datasets-data-in-bundle branch from 489096c to a8d81f9 Compare March 22, 2022 11:05
@github-actions
Copy link

Size Change: +40.1 kB (+1%)

Total Size: 5.05 MB

Filename Size Change
web/dist/15.11118865347d11499d90.js 0 B -1.07 kB (removed) 🏆
web/dist/15.74d2ffd280bdb1ddbcbd.css 0 B -925 B (removed) 🏆
web/dist/207.017b619ab07fa6583104.js 0 B -718 B (removed) 🏆
web/dist/352.4eeafe7ce8364eb35db9.js 0 B -4 kB (removed) 🏆
web/dist/424.b853a71c6e168b5aedac.js 0 B -15.9 kB (removed) 🏆
web/dist/501.851e98214d7704fb01f7.css 0 B -1.45 kB (removed) 🏆
web/dist/501.c1d0ccf3ea3b79bbebc2.js 0 B -4.21 kB (removed) 🏆
web/dist/529.91a8bc272eec257f52c9.js 0 B -1 kB (removed) 🏆
web/dist/662.6bd79078e8a02a4ac020.js 0 B -4.99 kB (removed) 🏆
web/dist/79.4bf021cb4f68a79bb86d.js 0 B -2.56 kB (removed) 🏆
web/dist/830.bb738aca9e52ad3a2279.js 0 B -9.1 kB (removed) 🏆
web/dist/947.24668554a7931922dfdd.css 0 B -2.82 kB (removed) 🏆
web/dist/947.4cfc615d92dd01ea17a6.js 0 B -4.43 kB (removed) 🏆
web/dist/956.229e37c1837420454174.js 0 B -799 B (removed) 🏆
web/dist/956.41188dd707723b069e34.css 0 B -794 B (removed) 🏆
web/dist/dark-bg.c0f9106e1ca75f113733ea6ae2df93b3.svg 0 B -858 B (removed) 🏆
web/dist/goals-screenshot.c3efbdf68d9b13d68f86652cd72962fe.png 0 B -82.5 kB (removed) 🏆
web/dist/intro-bg-md.aba7005a285d7a01d4e622cb72e17287.svg 0 B -1.27 kB (removed) 🏆
web/dist/intro-bg.8e0e83c79dbff037c5794ec84af0cc8f.png 0 B -9.07 kB (removed) 🏆
web/dist/main.66d84dcf70895f0590cb.js 0 B -141 kB (removed) 🏆
web/dist/main.e8a49f535446cc624fa4.css 0 B -18.8 kB (removed) 🏆
web/dist/runtime.db90bf4a235825182893.js 0 B -2.42 kB (removed) 🏆
web/dist/stats-screenshot.6654e031d1e0af05d08d3acae2801f55.png 0 B -83.1 kB (removed) 🏆
web/dist/vendors.49192381f5e41301b5fc.js 0 B -138 kB (removed) 🏆
web/dist/15.829d324521d775ba13d5.js 1.07 kB +1.07 kB (new file) 🆕
web/dist/15.f3d4b3c9a38c89c33d5e.css 923 B +923 B (new file) 🆕
web/dist/207.44f04c3f55c7d619e89d.js 726 B +726 B (new file) 🆕
web/dist/352.7242f5a3e9385eb2478e.js 4.02 kB +4.02 kB (new file) 🆕
web/dist/424.fab409e4ee8ec2b51bf4.js 16.1 kB +16.1 kB (new file) 🆕
web/dist/529.2c1a41b49518fa3f95ef.js 973 B +973 B (new file) 🆕
web/dist/561.15b2004ae88614ef2151.js 5.3 kB +5.3 kB (new file) 🆕
web/dist/561.b7c253739b258afc3465.css 3.43 kB +3.43 kB (new file) 🆕
web/dist/662.4354215267b22ff3058e.js 5.14 kB +5.14 kB (new file) 🆕
web/dist/79.e278d4628c5dc559bec5.js 2.58 kB +2.58 kB (new file) 🆕
web/dist/814.159ccdc70696441c7f32.css 3.48 kB +3.48 kB (new file) 🆕
web/dist/814.7eb8e2f33c1b3fc4a46d.js 12.3 kB +12.3 kB (new file) 🆕
web/dist/830.00b6e225283effe899b4.js 12.6 kB +12.6 kB (new file) 🆕
web/dist/956.0463b451f1e3c52881cd.css 783 B +783 B (new file) 🆕
web/dist/956.8234221a552d6168b5c6.js 809 B +809 B (new file) 🆕
web/dist/datasets-intro-background-triangle.f9cefca2b8deaf7d744d502075786992.svg 444 B +444 B (new file) 🆕
web/dist/datasets-intro-background.605b7d37da4b68bb689805dbdc00b80f.svg 502 B +502 B (new file) 🆕
web/dist/main.391475872581209b47dd.css 15 kB +15 kB (new file) 🆕
web/dist/main.cc721eb7fc600c040ea2.js 50.6 kB +50.6 kB (new file) 🆕
web/dist/releases/cv-corpus-1.json 2.92 kB +2.92 kB (new file) 🆕
web/dist/releases/cv-corpus-2.json 4.35 kB +4.35 kB (new file) 🆕
web/dist/releases/cv-corpus-3.json 4.45 kB +4.45 kB (new file) 🆕
web/dist/releases/cv-corpus-4-2019-12-10.json 5.52 kB +5.52 kB (new file) 🆕
web/dist/releases/cv-corpus-5-2020-06-22.json 9.96 kB +9.96 kB (new file) 🆕
web/dist/releases/cv-corpus-5-singleword.json 2.53 kB +2.53 kB (new file) 🆕
web/dist/releases/cv-corpus-5.1-2020-06-22.json 9.97 kB +9.97 kB (new file) 🆕
web/dist/releases/cv-corpus-5.1-singleword.json 2.52 kB +2.52 kB (new file) 🆕
web/dist/releases/cv-corpus-6.0-2020-12-11.json 10.7 kB +10.7 kB (new file) 🆕
web/dist/releases/cv-corpus-6.0-singleword.json 3.43 kB +3.43 kB (new file) 🆕
web/dist/releases/cv-corpus-6.1-2020-12-11.json 10.9 kB +10.9 kB (new file) 🆕
web/dist/releases/cv-corpus-6.1-singleword.json 3.52 kB +3.52 kB (new file) 🆕
web/dist/releases/cv-corpus-7.0-2021-07-21.json 13.4 kB +13.4 kB (new file) 🆕
web/dist/releases/cv-corpus-7.0-singleword.json 3.63 kB +3.63 kB (new file) 🆕
web/dist/releases/cv-corpus-8.0-2022-01-19.json 13.6 kB +13.6 kB (new file) 🆕
web/dist/runtime.1c9bd7185756db511616.js 2.44 kB +2.44 kB (new file) 🆕
web/dist/vendors.3c07130f2c288c8fdc12.js 331 kB +331 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
web/dist/_1.0e56b932185b30820371d900f050d308.svg 1.19 kB
web/dist/_2.43ce69138287cf30a8e732f0c6483e26.svg 1.33 kB
web/dist/_3.5fd904b832e87265ff95a3ae9ab313a2.svg 1.34 kB
web/dist/1-1.f54adbc9a98c02e5fd36263af27aa36a.png 8.57 kB
web/dist/1-2.f12a1c58eb0dff935d65e12f7c82ec5a.png 7.66 kB
web/dist/1-3.59cb8c7d1e863d131f560ff7b23ef307.png 14.1 kB
web/dist/1-4.417eef507c94e9c8c45bd90ce887b103.png 24.4 kB
web/dist/1-5.61f6fc8c2d1fe885d0d09ae6f0b68a8b.png 15.8 kB
web/dist/1-6.0e77c311f2d0392e5b120a26393d35d5.png 12.3 kB
web/dist/1-red-copy.e17e9b7e7bfb78442594dd0e495e39f2.svg 9.27 kB
web/dist/2-1.a9dc3c7eda3b9ca10659506d77593e3e.png 7.09 kB
web/dist/2-2.59cb8c7d1e863d131f560ff7b23ef307.png 14.1 kB
web/dist/2-3.bc18aff41d710133cbc2f31118d4ddf4.png 10.3 kB
web/dist/2-4.38465cc60db58d68dc019db2662fd02f.png 8.65 kB
web/dist/2-5.5d8fb114abc016223203a0b9b25e2540.png 8.42 kB
web/dist/207.3e1a3620ca8daf8c15ec.css 812 B
web/dist/424.135fb63d9f4a9338659d.css 9.88 kB
web/dist/529.8add268fca360263a178.css 1.35 kB
web/dist/662.6fecdc12d9e99f09ff86.css 2.97 kB
web/dist/79.17f1b21c44a1399aecf2.css 1.98 kB
web/dist/830.c5189f070dc34f458780.css 3.21 kB
web/dist/background-wave-error.ecc46c962bdede1abb49ca6ac9b4fe4d.svg 403 B
web/dist/challenge-mtn-post.2760e5efd8516a517fbb8a4fc53e5690.svg 3.35 kB
web/dist/challenge-mtn-pre.7f923a2424da36611a6fd5abc780767b.svg 3.41 kB
web/dist/chevron-left.e74b387f4aa5d9d9aec594cf3155f9e4.svg 291 B
web/dist/chevron-right.9342d62734db9639db14775d4c73859b.svg 293 B
web/dist/chrome-color.4e16297291336682bc8bbed3e8901d71.svg 1.97 kB
web/dist/close-black.a794ab384389fc57b7bf0c1143dbac71.svg 820 B
web/dist/close.407c0135d219d1cb1e6db21fa75f6938.svg 819 B
web/dist/contact.6c9c8bd4df68d2b52ff38e2778986820.svg 975 B
web/dist/contribute.3ebd61ec4c504e270260213744adc120.png 599 kB
web/dist/cv-logo-bw.270d5891c1700962adc939d607aca855.svg 2.36 kB
web/dist/cv-logo-one-color-white.3b47f3ba45b69f4a3886094089c007ac.svg 2.9 kB
web/dist/dashboard.fecdda15da81e40325f84359b59de997.png 954 kB
web/dist/deepspeech.fb7d3b38751dae9032037d8af89b0791.png 10.7 kB
web/dist/deepspeech@2x.be59450d6c9468b99d739851adefa98b.png 31.6 kB
web/dist/deepspeech@3x.11605acf68bb280e4bb2013f8270b0cb.png 63.2 kB
web/dist/discourse.719453216aeb8a25fe8fa0d0273dc123.png 16.4 kB
web/dist/discourse.e709f94f3a145b103f3c8370d20eb674.svg 479 B
web/dist/discourse@2x.45a00eaccf0bd6e15013ae746a1ce391.png 44.7 kB
web/dist/discourse@3x.4983f52ae76ea17e977f898c39c571c5.png 73.9 kB
web/dist/down-arrow.e66dc37d81d1d4fe0d1317edadfded9a.svg 394 B
web/dist/email-bg-light.0066335e3fec3321f97b22a215249488.png 12.5 kB
web/dist/email-bg-md-light.eea7d4d4624f60cfc38c7d83006be13d.svg 912 B
web/dist/email-bg-md.e44cd38e9aba8abebd38481273045a71.svg 1.1 kB
web/dist/email-bg.5fee4f971c5bfa05e7848cf5b2807136.png 4.22 kB
web/dist/Eq.2074a0c0d249c1ac6be686f3f49f31e3.svg 16.9 kB
web/dist/exclamation.8ff079b062644e068210078cf2f88c90.svg 524 B
web/dist/fading.2e034c0e0b80860d9000000938d7e843.svg 321 B
web/dist/fading.ac89fe055e9a7f6905c20abc136a1a6c.svg 632 B
web/dist/feedback.1038f8e6b14913b8387c92d3b3f33b03.png 26.4 kB
web/dist/feedback@2x.815f46ccbb3edb4d712364d43dbe82f1.png 82.6 kB
web/dist/feedback@3x.99ae4e5b1df3c524e4cad8f7adc40391.png 269 kB
web/dist/ff-color.065faaf607fac0ccefafddbf63793c50.svg 4.3 kB
web/dist/github.aae4752d9340a76a92d230201aa3ef38.svg 848 B
web/dist/globe_black.0c979a2c13930f6054fb2eaedf14d8f3.svg 948 B
web/dist/globe.6f77803a99f0f7f15d53db98570b2d1f.svg 947 B
web/dist/grid.9309fc755409371af4c51917119d9ea4.svg 387 B
web/dist/hex-done.f05903e714a469816bdc3c9b72e751ed.svg 335 B
web/dist/hex.1a61364b6102f9662f3a81105b05929a.svg 301 B
web/dist/home.694fb93c834ab0e17a006dd8dd863c2e.svg 505 B
web/dist/ibm.0f0255c40ecafa14c53ad750e04d4287.svg 498 B
web/dist/keyboard.162f944a62a997e428452e390ccdf81d.svg 356 B
web/dist/lenovo.4a2fd90737ba6ca124bd83704d563b9e.svg 926 B
web/dist/librispeech.84e216dd6dddafda65321961b9b72247.png 155 B
web/dist/light-waves.2293e8ba3f658284ed50234152b419cf.svg 1.7 kB
web/dist/listen-bg.a69b80bc48d1bca46170d9de5fb23606.svg 1.98 kB
web/dist/listen.0ec85689a0d17889079bc9c24486dc53.svg 1.8 kB
web/dist/mail.ed25b6d9711be58e9ea59aab90a9470e.svg 1 kB
web/dist/mars-avatar.6e8aeebd12e814ce19d836bee541b069.svg 1.36 kB
web/dist/mars-blue.5bb650cc8279cc152ba5c73cf770bdf0.svg 3.48 kB
web/dist/mars-sad.fa2d488fbbddcc42b1617d7c8282d74d.svg 6.24 kB
web/dist/mars.1b6751d185175a2761601c030cc2e584.svg 8.54 kB
web/dist/mars.5370c32c01e8e428c113f614a9187721.svg 3.55 kB
web/dist/mars.9293fd371297da0682316004e3ae6cd2.svg 2.7 kB
web/dist/mesh.9061c14cb17230157a3050e22a81500e.svg 484 B
web/dist/mic.b52d8e1b378f15cd9a82183276bc34fc.svg 432 B
web/dist/mozilla.d5745de755c8187b4a999a1e035993a4.svg 465 B
web/dist/play.441db78d48bafca16c58cae5eb2bd9fb.svg 379 B
web/dist/play.e514fd69a5ec96b85110ebe44f49dbcf.svg 2.15 kB
web/dist/plus.badfc2e20218543ecbbf015ca64ac785.svg 330 B
web/dist/red-robot.0c6d0ba84fca3bf61fe3ffab8e76a782.svg 1.1 MB
web/dist/robot.8049ebd091c9ee59675becafd5708446.png 33.7 kB
web/dist/robot.dece5f93221179c48f544b5d3757b9b3.png 52.1 kB
web/dist/safari-color.8a3db6670f5b38604a5386be2407f048.svg 8.71 kB
web/dist/sap.447c7ca3440c1638a9c071c2bb647e24.svg 849 B
web/dist/search.89fe1f8c7d4cc0a95eb96a834a289ef1.svg 428 B
web/dist/segment-dots.dd5a9a794dc1dce0e32344644002553b.svg 471 B
web/dist/sodedif.aeec68a0aac2c79de98bc1322c020d7f.png 1.95 kB
web/dist/speak-bg.fbbf0c25514aa32e66b7c1a67fe11dce.svg 1.98 kB
web/dist/speak.16315f4e26d3f34fdaa81b1776d94406.svg 1.69 kB
web/dist/star.3f89142a8319d79e7da6444b3fa42deb.svg 438 B
web/dist/star.c188df5c81773613e97cd7b2a039f91e.svg 557 B
web/dist/stars-disabled.d6f3860ad0635e717f515c0b36216a78.svg 2.09 kB
web/dist/stars.2826849ceb67f6bc2cf1d20c20810e0b.svg 1.57 kB
web/dist/stars.528a58b388b3a1cf7ce2bdae4e0cd197.svg 2.13 kB
web/dist/success.38537c41664b55a40b79e859cd3488e8.svg 350 B
web/dist/success.8eca68289b3dedbf6835aa31cc79c8d1.svg 1.47 kB
web/dist/support.27a6cee2843c5c4967e21e26b90aeb35.svg 1.94 kB
web/dist/tatoeba.5f34bf81739b53bb1c55ab52b30ab738.png 21 kB
web/dist/ted.457862c47e287c7a06cfd9fc233071b1.png 172 B
web/dist/upload.4c5d858107573e5e3c6c158c1ce79a8c.svg 551 B
web/dist/voxforge.61abcacc811f36df6742375e6e5811dd.png 10.5 kB
web/dist/wave-2.7006373745b6f87e354a8f5937c6be14.svg 816 B
web/dist/wave-blue.3926a552ff63b282e5bb04917d3addc2.svg 4.32 kB
web/dist/wave-grey.11b3e76038e6e11f658e4794fcf1f960.svg 499 B
web/dist/wave-grey.ea5eddf207775751e709b81a20ccfbe6.svg 1.9 kB
web/dist/wave-top.3cda298247cab7df201b84a457a3c5a9.png 8.66 kB
web/dist/wave-top.a2d249fc3a1ed2a0f4470ead20e29b3b.png 5.28 kB
web/dist/wave.0a46013b13d6940e5e82e00b5fe21d60.png 196 kB
web/dist/wave.80f7e61ef0699fd6c9519a896bcbe04f.svg 1.01 kB
web/dist/wave.935d6885e23df0f366cb079dafdd6408.svg 959 B
web/dist/wave.c867f511c5b44b3bec15849f0933c456.svg 1.03 kB
web/dist/wave.e1b1f17d8a10adfb9b10e180897fa8a8.svg 1.07 kB
web/dist/waves-md.ee4ab9b9a1f67e7d1926bcda679003c4.svg 1.66 kB
web/dist/waves.10a7bf91dc1491f606e5d2d3751a870f.svg 1.85 kB
web/dist/waves.9989b1ee6ce7f16cd3e912ebd0779815.png 166 kB
web/dist/waves.c183c4f072be63570f62c5f26254cc2d.png 33.4 kB
web/dist/waves.c3b38f86f0f0d8d1b2c080bab62c2cb5.svg 1.11 kB
web/dist/waves.c4c2e5df42e32f18198b149ff8b3dc05.png 21.2 kB
web/dist/waves@2x.ae93852faff9035fcc4501d769165e62.png 113 kB
web/dist/waves@3x.a026d977717ce541ca450dd7207ce4bd.png 227 kB

compressed-size-action

@zcolleyz zcolleyz merged commit 1f0dfe8 into main Mar 22, 2022
@zcolleyz zcolleyz deleted the fix-datasets-data-in-bundle branch March 22, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozgzh mozgzh mozgzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset page description: design is not l10n-friendly
2 participants
@zcolleyz @mozgzh