Better non-production-banner #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcolleyz
force-pushed
the
better-non-production-banner
branch
from
f51ed48
to
c861507
Compare
|
Size Change: -203 B (0%) Total Size: 4.78 MB
ℹ️ View Unchanged
|
added 2 commits
March 24, 2022 12:22
zcolleyz
force-pushed
the
better-non-production-banner
branch
from
c861507
to
59ad8f6
Compare
mozgzh
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The banner on staging/dev/local makes it hard to compare between those and production.
These changes make the non-production-banner simpler and float. It also makes the close button bigger so it's easier to close.
Also this deletes lots of dead code around those files.
Before
After