Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when native name is sometimes used instead of ISO code #3795

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

mozgzh
Copy link
Contributor

@mozgzh mozgzh commented Sep 12, 2022

On startup, in some circumstances, the native name is saved (when inserting new languages) to the wrong column instead of the ISO code.

Full fix for #3775

Fixed:

  • native names finding their way into the names column in locales
  • removing migration that was used to add data to the db that depended on pre-existing data
  • moved adding variants to the start up flow

@mozgzh mozgzh requested a review from a team as a code owner September 12, 2022 14:00
@mozgzh mozgzh requested review from data-sync-user and removed request for a team September 12, 2022 14:00
@github-actions
Copy link

github-actions bot commented Sep 12, 2022

Size Change: -2 B (0%)

Total Size: 4.82 MB

ℹ️ View Unchanged
Filename Size Change
web/dist/1-1.****************.png 8.57 kB 0 B
web/dist/1-2.****************.png 7.66 kB 0 B
web/dist/1-3.****************.png 14.1 kB 0 B
web/dist/1-4.****************.png 24.4 kB 0 B
web/dist/1-5.****************.png 15.8 kB 0 B
web/dist/1-6.****************.png 12.3 kB 0 B
web/dist/1-red-copy.****************.svg 9.27 kB 0 B
web/dist/15.****************.js 1.04 kB 0 B
web/dist/15.****************.css 851 B 0 B
web/dist/2-1.****************.png 7.09 kB 0 B
web/dist/2-2.****************.png 14.1 kB 0 B
web/dist/2-3.****************.png 10.3 kB 0 B
web/dist/2-4.****************.png 8.65 kB 0 B
web/dist/2-5.****************.png 8.42 kB 0 B
web/dist/262.****************.css 3.18 kB 0 B
web/dist/262.****************.js 4.94 kB 0 B
web/dist/297.****************.js 6.65 kB 0 B
web/dist/297.****************.css 4.08 kB 0 B
web/dist/372.****************.css 630 B 0 B
web/dist/372.****************.js 2.6 kB 0 B
web/dist/424.****************.js 16.2 kB 0 B
web/dist/424.****************.css 9.76 kB 0 B
web/dist/490.****************.js 5.21 kB 0 B
web/dist/490.****************.css 1.83 kB 0 B
web/dist/529.****************.js 903 B 0 B
web/dist/529.****************.css 1.28 kB 0 B
web/dist/561.****************.js 5.26 kB 0 B
web/dist/561.****************.css 3.06 kB 0 B
web/dist/569.****************.css 735 B 0 B
web/dist/616.****************.js 1.46 kB 0 B
web/dist/616.****************.css 494 B 0 B
web/dist/662.****************.css 3.61 kB 0 B
web/dist/662.****************.js 6.38 kB 0 B
web/dist/782.****************.js 6.13 kB 0 B
web/dist/79.****************.css 1.9 kB 0 B
web/dist/79.****************.js 2.65 kB 0 B
web/dist/814.****************.js 12 kB 0 B
web/dist/814.****************.css 3.31 kB 0 B
web/dist/830.****************.css 3.07 kB 0 B
web/dist/830.****************.js 13 kB 0 B
web/dist/863.****************.css 494 B 0 B
web/dist/863.****************.js 476 B 0 B
web/dist/956.****************.css 1.35 kB 0 B
web/dist/956.****************.js 1.89 kB 0 B
web/dist/background-wave-error.****************.svg 403 B 0 B
web/dist/background-wave-success.****************.svg 548 B 0 B
web/dist/background-wave.****************.svg 280 B 0 B
web/dist/challenge-mtn-post.****************.svg 3.35 kB 0 B
web/dist/challenge-mtn-pre.****************.svg 3.41 kB 0 B
web/dist/chevron-left.****************.svg 291 B 0 B
web/dist/chevron-right.****************.svg 293 B 0 B
web/dist/chrome-color.****************.svg 1.97 kB 0 B
web/dist/close-black.****************.svg 820 B 0 B
web/dist/close.****************.svg 819 B 0 B
web/dist/contact.****************.svg 975 B 0 B
web/dist/contribute.****************.png 599 kB 0 B
web/dist/cv-logo-black.****************.svg 2.36 kB 0 B
web/dist/cv-logo-white.****************.svg 2.9 kB 0 B
web/dist/dashboard.****************.png 954 kB 0 B
web/dist/datasets-intro-background-triangle.****************.svg 444 B 0 B
web/dist/datasets-intro-background.****************.svg 502 B 0 B
web/dist/deepspeech.****************.png 10.7 kB 0 B
web/dist/deepspeech@2x.****************.png 31.6 kB 0 B
web/dist/deepspeech@3x.****************.png 63.2 kB 0 B
web/dist/discourse.****************.png 16.4 kB 0 B
web/dist/discourse.****************.svg 479 B 0 B
web/dist/discourse@2x.****************.png 44.7 kB 0 B
web/dist/discourse@3x.****************.png 73.9 kB 0 B
web/dist/down-arrow.****************.svg 394 B 0 B
web/dist/email-bg-light.****************.png 12.5 kB 0 B
web/dist/email-bg-md-light.****************.svg 912 B 0 B
web/dist/email-bg-md.****************.svg 1.1 kB 0 B
web/dist/email-bg.****************.png 4.22 kB 0 B
web/dist/exclamation.****************.svg 524 B 0 B
web/dist/fading.****************.svg 321 B 0 B
web/dist/feedback.****************.png 26.4 kB 0 B
web/dist/feedback@2x.****************.png 82.6 kB 0 B
web/dist/feedback@3x.****************.png 269 kB 0 B
web/dist/ff-color.****************.svg 4.3 kB 0 B
web/dist/github.****************.svg 848 B 0 B
web/dist/globe_black.****************.svg 948 B 0 B
web/dist/globe.****************.svg 947 B 0 B
web/dist/grid.****************.svg 387 B 0 B
web/dist/hex-done.****************.svg 335 B 0 B
web/dist/hex.****************.svg 301 B 0 B
web/dist/home.****************.svg 505 B 0 B
web/dist/ibm.****************.svg 498 B 0 B
web/dist/keyboard.****************.svg 356 B 0 B
web/dist/languages/test.json 20 B 0 B
web/dist/lenovo.****************.svg 926 B 0 B
web/dist/librispeech.****************.png 155 B 0 B
web/dist/light-waves.****************.svg 1.7 kB 0 B
web/dist/listen-bg.****************.svg 1.98 kB 0 B
web/dist/listen.****************.svg 1.8 kB 0 B
web/dist/mail.****************.svg 1 kB 0 B
web/dist/main.****************.js 34.3 kB 0 B
web/dist/main.****************.css 8.43 kB -2 B (0%)
web/dist/mars-avatar.****************.svg 1.36 kB 0 B
web/dist/mars-blue.****************.svg 3.48 kB 0 B
web/dist/mars-email-success.****************.svg 7.76 kB 0 B
web/dist/mars-request.****************.svg 7.05 kB 0 B
web/dist/mars-sad.****************.svg 6.24 kB 0 B
web/dist/mars.****************.svg 2.7 kB 0 B
web/dist/mesh.****************.svg 484 B 0 B
web/dist/mic.****************.svg 432 B 0 B
web/dist/mozilla.****************.svg 465 B 0 B
web/dist/play.****************.svg 2.15 kB 0 B
web/dist/plus.****************.svg 330 B 0 B
web/dist/red-robot.****************.svg 1.1 MB 0 B
web/dist/releases/cv-corpus-1.json 2.92 kB 0 B
web/dist/releases/cv-corpus-10.0-2022-07-04.json 14.9 kB 0 B
web/dist/releases/cv-corpus-2.json 4.35 kB 0 B
web/dist/releases/cv-corpus-3.json 4.45 kB 0 B
web/dist/releases/cv-corpus-4-2019-12-10.json 5.52 kB 0 B
web/dist/releases/cv-corpus-5-2020-06-22.json 9.96 kB 0 B
web/dist/releases/cv-corpus-5-singleword.json 2.53 kB 0 B
web/dist/releases/cv-corpus-5.1-2020-06-22.json 9.97 kB 0 B
web/dist/releases/cv-corpus-5.1-singleword.json 2.52 kB 0 B
web/dist/releases/cv-corpus-6.0-2020-12-11.json 10.7 kB 0 B
web/dist/releases/cv-corpus-6.0-singleword.json 3.43 kB 0 B
web/dist/releases/cv-corpus-6.1-2020-12-11.json 10.9 kB 0 B
web/dist/releases/cv-corpus-6.1-singleword.json 3.52 kB 0 B
web/dist/releases/cv-corpus-7.0-2021-07-21.json 13.4 kB 0 B
web/dist/releases/cv-corpus-7.0-singleword.json 3.63 kB 0 B
web/dist/releases/cv-corpus-8.0-2022-01-19.json 13.6 kB 0 B
web/dist/releases/cv-corpus-9.0-2022-04-27.json 14.8 kB 0 B
web/dist/robot.****************.png 52.1 kB 0 B
web/dist/runtime.****************.js 2.47 kB 0 B
web/dist/safari-color.****************.svg 8.71 kB 0 B
web/dist/sap.****************.svg 849 B 0 B
web/dist/search.****************.svg 428 B 0 B
web/dist/segment-dots.****************.svg 471 B 0 B
web/dist/sodedif.****************.png 1.95 kB 0 B
web/dist/speak-bg.****************.svg 1.98 kB 0 B
web/dist/speak.****************.svg 1.69 kB 0 B
web/dist/star.****************.svg 557 B 0 B
web/dist/stars-disabled.****************.svg 2.09 kB 0 B
web/dist/stars.****************.svg 2.13 kB 0 B
web/dist/success.****************.svg 1.47 kB 0 B
web/dist/support.****************.svg 1.94 kB 0 B
web/dist/tatoeba.****************.png 21 kB 0 B
web/dist/ted.****************.png 172 B 0 B
web/dist/upload.****************.svg 551 B 0 B
web/dist/vendors.****************.js 330 kB 0 B
web/dist/voxforge.****************.png 10.5 kB 0 B
web/dist/wave-1.****************.svg 444 B 0 B
web/dist/wave-2.****************.svg 816 B 0 B
web/dist/wave-3.****************.svg 464 B 0 B
web/dist/wave-blue.****************.svg 4.32 kB 0 B
web/dist/wave-eq.****************.svg 1.03 kB 0 B
web/dist/wave-fading.****************.svg 341 B 0 B
web/dist/wave-grey.****************.svg 1.9 kB 0 B
web/dist/wave-top.****************.png 5.28 kB 0 B
web/dist/wave.****************.png 196 kB 0 B
web/dist/wave.****************.svg 1.07 kB 0 B
web/dist/waves-md.****************.svg 1.66 kB 0 B
web/dist/waves.****************.svg 1.11 kB 0 B
web/dist/waves.****************.png 21.2 kB 0 B
web/dist/waves@2x.****************.png 113 kB 0 B
web/dist/waves@3x.****************.png 227 kB 0 B

compressed-size-action

@mozgzh mozgzh merged commit 16958c5 into main Sep 14, 2022
@mozgzh mozgzh deleted the fix-language-import branch September 14, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants