New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify purposes and processes in the Sentences documentation #3804
Conversation
bunch of additional informations that (I think that) is useful for beginners... Adding all info I would have found interesting when I started to look at this project. Fell free to correct and modify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the documentation! I've left a few comments and suggestions.
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
I'll handle your comment more properly tomorrow ⏳ |
Thanks for the changes! I'm not the owner of this so I won't be able to give final approval, however I can have another look once you've changed the rest, just ping me here :) Thanks again! |
Thanks @CapitainFlam and @MichaelKohler for the PR/CR. @ftyers I'd love your thoughts as well. Once everyone's happy with the changes, I'll review and merge 🚀 |
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
"next time there is a release" is still unclear :-/ Co-authored-by: Michael Kohler <me@michaelkohler.info>
according to comments from review, rework of it.
removing details, and sending reader to ReadMe file
Greetings everyone 👋 , I forked the project, loaded it on my local GitHub Desktop app, and changed file in a (I hope) appropriated way ✨ . 👨🚀 👩🚀 @MichaelKohler , @mozgzh , @ftyers , Please have a look 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the corrections and additions. I've left a few more comments and suggestions :)
As suggested in review Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review Co-authored-by: Michael Kohler <me@michaelkohler.info>
As suggested in review Co-authored-by: Michael Kohler <me@michaelkohler.info>
I'll let the Common Voice team do the final review here. @mozgzh feel free to redirect the review within the team, you know better who should do the review here :) |
Looks good to me. Thanks for the PR @CapitainFlam and Review @MichaelKohler 🚀 |
bunch of additional informations that (I think that) is useful for beginners... Adding all info I would have found interesting when I started to look at this project. Feel free to correct and modify.
Pull Request Form
Type of Pull Request
Acknowledging contributors