Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify purposes and processes in the Sentences documentation #3804

Merged
merged 17 commits into from Oct 11, 2022

Conversation

CapitainFlam
Copy link
Contributor

@CapitainFlam CapitainFlam commented Sep 19, 2022

bunch of additional informations that (I think that) is useful for beginners... Adding all info I would have found interesting when I started to look at this project. Feel free to correct and modify.

Pull Request Form

Type of Pull Request

  • Bulk sentence upload
  • Related to a listed issue
  • Other
  • New user more readable docs and useful links

Acknowledging contributors

bunch of additional informations that (I think that) is useful for beginners...
Adding all info I would have found interesting when I started to look at this project. Fell free to correct and modify.
@CapitainFlam CapitainFlam requested a review from a team as a code owner September 19, 2022 11:50
@CapitainFlam CapitainFlam requested review from data-sync-user and removed request for a team September 19, 2022 11:50
Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the documentation! I've left a few comments and suggestions.

docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
CapitainFlam and others added 4 commits September 19, 2022 22:46
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
@CapitainFlam
Copy link
Contributor Author

I'll handle your comment more properly tomorrow ⏳

@MichaelKohler
Copy link
Member

Thanks for the changes! I'm not the owner of this so I won't be able to give final approval, however I can have another look once you've changed the rest, just ping me here :) Thanks again!

@MichaelKohler MichaelKohler changed the title bunch of additional informations Clarify purposes and processes in the Sentences documentation Sep 19, 2022
@mozgzh
Copy link
Contributor

mozgzh commented Sep 20, 2022

Thanks @CapitainFlam and @MichaelKohler for the PR/CR. @ftyers I'd love your thoughts as well. Once everyone's happy with the changes, I'll review and merge 🚀

CapitainFlam and others added 5 commits September 21, 2022 09:45
Co-authored-by: Michael Kohler <me@michaelkohler.info>
Co-authored-by: Michael Kohler <me@michaelkohler.info>
"next time there is a release" is still unclear :-/

Co-authored-by: Michael Kohler <me@michaelkohler.info>
according to comments from review, rework of it.
removing details, and sending reader to ReadMe file
@CapitainFlam CapitainFlam requested review from MichaelKohler and removed request for data-sync-user September 21, 2022 08:39
@CapitainFlam
Copy link
Contributor Author

Greetings everyone 👋 ,

I forked the project, loaded it on my local GitHub Desktop app, and changed file in a (I hope) appropriated way ✨ .

👨‍🚀 👩‍🚀 @MichaelKohler , @mozgzh , @ftyers ,

Please have a look 👀

Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections and additions. I've left a few more comments and suggestions :)

docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
docs/SENTENCES.md Show resolved Hide resolved
docs/SENTENCES.md Outdated Show resolved Hide resolved
CapitainFlam and others added 5 commits September 22, 2022 21:06
As suggested in review

Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review

Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review

Co-authored-by: Michael Kohler <me@michaelkohler.info>
As proposed in review

Co-authored-by: Michael Kohler <me@michaelkohler.info>
As suggested in review

Co-authored-by: Michael Kohler <me@michaelkohler.info>
docs/SENTENCES.md Outdated Show resolved Hide resolved
@MichaelKohler MichaelKohler requested review from mozgzh and removed request for MichaelKohler September 23, 2022 17:35
@MichaelKohler
Copy link
Member

I'll let the Common Voice team do the final review here. @mozgzh feel free to redirect the review within the team, you know better who should do the review here :)

@mozgzh
Copy link
Contributor

mozgzh commented Oct 11, 2022

Looks good to me. Thanks for the PR @CapitainFlam and Review @MichaelKohler 🚀

@mozgzh mozgzh merged commit 841eaa5 into common-voice:main Oct 11, 2022
@CapitainFlam CapitainFlam deleted the patch-2 branch October 12, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants