-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct second person message #4228
Conversation
Hello @stuartlangridge thank you for your contribution. Could you update this test to look for Once again thanks for your contribution and let me know if you have any questions |
Corresponding with change to web/locales/en/messages.ftl `confirm-join-mailing-list`
PR updated as requested! |
Hello @stuartlangridge it seems you also need to make the same change you just made here and here Sorry I didn't see these earlier. The tests should be fine after these changes are made. |
Corresponding with change to web/locales/en/messages.ftl `confirm-join-mailing-list`; there are two tests in this file, it seems
And a third use of the same text
Yup, my fault for not checking :) I think they're all changed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution 🎉
To fix #4115
Pull Request Form
Type of Pull Request
Acknowledging contributors