-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OI-2905: Add sentence domain dropdown and styling #4362
OI-2905: Add sentence domain dropdown and styling #4362
Conversation
…ropdown-field-for-domain-list
Size Change: +508 B (0%) Total Size: 5.94 MB
ℹ️ View Unchanged
|
general: 'General', | ||
healthcare: 'Healthcare', | ||
history_law_government: 'History, Law and Government', | ||
language_fundamentals: 'Language Fundamentals (e.g. Digits, Letters, Money)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think that this is ok, but I might make the explanations a separate string. E.g. there is only an explanation for one language_fundamentals
, but I think there could potentially be explanations for various.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, only why does only "Language fundamentals" have an (e.g. ...)
part, and could that part be in a separate string?
No description provided.