Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Only show "filtered" sentences header when there are filtered sentences #99

Closed
MichaelKohler opened this issue Jan 11, 2019 · 1 comment · Fixed by #105
Closed

Only show "filtered" sentences header when there are filtered sentences #99

MichaelKohler opened this issue Jan 11, 2019 · 1 comment · Fixed by #105
Assignees
@MichaelKohler
Labels
bug Something isn't working frontend
Milestone
MVP

Comments

@MichaelKohler
Copy link
Member

  1. Write sentences and click on submit - make sure there are no invalid ones
  2. Review your own sentences
  3. Reject one sentence
  4. Notice that the "filtered" header gets shown, even though there are no filtered sentences
@MichaelKohler MichaelKohler added bug Something isn't working frontend labels Jan 11, 2019
@MichaelKohler MichaelKohler added this to the MVP milestone Jan 11, 2019
@MichaelKohler MichaelKohler self-assigned this Jan 11, 2019
@MichaelKohler MichaelKohler added this to Backlog in MVP + Beta Jan 11, 2019
@MichaelKohler MichaelKohler moved this from Backlog to In Progress in MVP + Beta Jan 13, 2019
MichaelKohler added a commit to MichaelKohler/sentence-collector that referenced this issue Jan 13, 2019
@MichaelKohler
Fix: only show 'filtered sentences' if there are filtered sentences (f…
2402607 
…ixes common-voice#99)
@MichaelKohler MichaelKohler mentioned this issue Jan 13, 2019
Merged
@MichaelKohler MichaelKohler moved this from In Progress to NOT DEPLOYED in MVP + Beta Jan 13, 2019
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
MVP
1 participant
@MichaelKohler