This repository has been archived by the owner on May 10, 2023. It is now read-only.
Add validator for Lao (lo) #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn: (sentence) => { | ||
| return sentence.length < MIN_LENGTH || sentence.length > MAX_LENGTH; | ||
| }, | ||
| error: `Number of characters must be between ${MIN_LENGTH} and ${MAX_LENGTH} (inclusive)`, |
There was a problem hiding this comment.
As with other languages, I think it would make sense to translate these error messages into Lao. What do you think?
There was a problem hiding this comment.
As with other languages, I think it would make sense to translate these error messages into Lao. What do you think?
I agree with you. I will translate these messages into Lao.
MichaelKohler
approved these changes
Dec 1, 2022
MichaelKohler
pushed a commit
that referenced
this pull request
Dec 1, 2022
|
🎉 This PR is included in version 2.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose code for Lao language validator.
It's basic validator code.