Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDL structs are not handled #72

Closed
dinithiW opened this issue Aug 23, 2021 · 3 comments · Fixed by #150
Closed

WDL structs are not handled #72

dinithiW opened this issue Aug 23, 2021 · 3 comments · Fixed by #150
Labels
good first issue Good for newcomers

Comments

@dinithiW
Copy link
Contributor

Currently, WDL specific custom compound type struct is not translated by the translator (https://github.com/openwdl/wdl/blob/main/versions/1.1/SPEC.md#custom-types-structs)

In WDL documents, after the definition of these structs, they can be referenced in the input, output and command sections. A workflow using struct type is shown in the this link. https://github.com/broadinstitute/warp/blob/b3f5c898d1b535aaca8dc9e9f4223697a7a0a9a9/pipelines/skylab/build_indices/BuildIndices.wdl#L3

Referencing in input section: https://github.com/broadinstitute/warp/blob/b3f5c898d1b535aaca8dc9e9f4223697a7a0a9a9/pipelines/skylab/build_indices/BuildIndices.wdl#L52
Referencing in output section: https://github.com/broadinstitute/warp/blob/b3f5c898d1b535aaca8dc9e9f4223697a7a0a9a9/pipelines/skylab/build_indices/BuildIndices.wdl#L126
Referencing in command section: https://github.com/broadinstitute/warp/blob/b3f5c898d1b535aaca8dc9e9f4223697a7a0a9a9/pipelines/skylab/build_indices/BuildIndices.wdl#L68

@mr-c mr-c added the good first issue Good for newcomers label Sep 24, 2021
@kinow
Copy link
Member

kinow commented Oct 28, 2021

I cloned the repository and read the README and parts of the code today. Then decided to choose a random WDL from the warp repository, and chose exactly the build_indices mentioned above. Had the error when trying to translate it, and searched in the issues, finding this one 😬

Any pointers on how this could be fixed? Would it be creating InputRecordSchema's and OutputRecordSchemas?

Thanks!
Bruno

@mr-c
Copy link
Member

mr-c commented Oct 28, 2021

I cloned the repository and read the README and parts of the code today. Then decided to choose a random WDL from the warp repository, and chose exactly the build_indices mentioned above. Had the error when trying to translate it, and searched in the issues, finding this one 😬

🙃😀

Any pointers on how this could be fixed? Would it be creating InputRecordSchema's and OutputRecordSchemas?

That is what I would do. Feel free to focus on solving the issue of how WDL struts are used in just one of the examples, versus making the perfect solution all at once.

Thanks!
Bruno

Thank you!

@mr-c mr-c closed this as completed in #150 Feb 3, 2022
mr-c pushed a commit that referenced this issue Feb 3, 2022
Fixes: #71
Fixes: #104
Fixes: #103
Closes: #72

Support WDL.Type.Struct
support select_first function
support div
support mul
support ceil
support size with input of array
support size with array of files
support time_minutes with size and ceil function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants