Feedback on tool-description.md #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments, suggestions and minor changes for the tool description document.
| @@ -83,22 +77,25 @@ capture the tool output, or propagate values from input to output. | |||
|
|
|||
| # Execution | |||
|
|
|||
| A [tool command line](#command-line-adapter) is built based on the | |||
| [Job order document](#job-order-document). | |||
| A *tool command line* is built based on the [adapter field](#command-line-adapter) of the | |||
There was a problem hiding this comment.
Hi, Tim. Thanks for the patch!
The JobOrder doesn't have an adapter field. Those are in the tool description document. The wording of "corresponding value from JobOrder for the adapter" was likely confusing. It refers to the input value.
For example, if you have
{
"inputs": {
"type": "object",
"properties": {
"int1": {"type": "integer"}
}
}and the job order
{
"inputs": {
"int1": 3
}
}... the "corresponding value in JobOrder for int1 is 3.
ghost
pushed a commit
that referenced
this pull request
Dec 24, 2014
Feedback on tool-description.md
ghost
merged commit
mr-c
added a commit
that referenced
this pull request
Apr 21, 2016
Setup very basic linting and CI through Travis.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments, suggestions and minor changes for the tool description document.