Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade a cwl 1.2 workflow fails #93

Closed
golharam opened this issue Nov 29, 2021 · 2 comments
Closed

Upgrade a cwl 1.2 workflow fails #93

golharam opened this issue Nov 29, 2021 · 2 comments

Comments

@golharam
Copy link

Using cwl-upgrader-1.2.2

$ cwl-upgrader rsem-merge.cwl
Processing rsem-merge.cwl
Unsupported cwlVersion: v1.2
Traceback (most recent call last):
File "/Users/golharr/workspace/NGS/RNASeq/env/bin/cwl-upgrader", line 8, in
sys.exit(main())
File "/Users/golharr/workspace/NGS/RNASeq/env/lib/python3.6/site-packages/cwlupgrader/main.py", line 59, in main
return run(parse_args(args))
File "/Users/golharr/workspace/NGS/RNASeq/env/lib/python3.6/site-packages/cwlupgrader/main.py", line 80, in run
document, args.v1_only, args.v1_1_only, args.dir, imports
File "/Users/golharr/workspace/NGS/RNASeq/env/lib/python3.6/site-packages/cwlupgrader/main.py", line 118, in upgrade_document
process_imports(document, imports, inner_updater, output_dir)
UnboundLocalError: local variable 'inner_updater' referenced before assignment

I would expect this to validate the cwl 1.2 workflow and ensure nothing is wrong, since there isn't an upgrade needed.

@tetron
Copy link
Member

tetron commented Nov 29, 2021

Hi @golharam

Yes that's an unfortunate oversight, running the upgrader on a v1.2 document should be a no-op but instead it fails because it didn't choose an updater (because there's nothing to update). I'll see about whipping up a quick fix.

@mr-c
Copy link
Member

mr-c commented Nov 29, 2021

Fixed in #94

@mr-c mr-c closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants