Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of no-op and invalid downgrade cases #94

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

tetron
Copy link
Member

@tetron tetron commented Nov 29, 2021

refs #93

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #94 (64b7003) into main (df84c39) will decrease coverage by 1.20%.
The diff coverage is 29.41%.

❗ Current head 64b7003 differs from pull request most recent head 9c0f879. Consider uploading reports for the commit 9c0f879 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   75.51%   74.31%   -1.21%     
==========================================
  Files           4        4              
  Lines         535      545      +10     
==========================================
+ Hits          404      405       +1     
- Misses        131      140       +9     
Impacted Files Coverage Δ
cwlupgrader/main.py 71.13% <29.41%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df84c39...9c0f879. Read the comment docs.

@tetron
Copy link
Member Author

tetron commented Nov 29, 2021

How the heck does mypy pass on an unbound variable but not pass on a None-assigned variable that is clearly reassigned to non-None on every possible code path?

@mr-c mr-c merged commit 4c62c83 into main Nov 29, 2021
@mr-c mr-c deleted the fix-noop branch November 29, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants