Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Working Groups section #196

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add Working Groups section #196

merged 2 commits into from
Feb 14, 2024

Conversation

GlassOfWhiskey
Copy link
Contributor

This commit adds a Working Groups section to track CWL focus groups on specific topics. The CWL4HPC working group has been added as an example, hoping that more activities will come in the future.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for cwl-website ready!

Name Link
🔨 Latest commit ff5b9c6
🔍 Latest deploy log https://app.netlify.com/sites/cwl-website/deploys/65ccde7e280b430008dbb165
😎 Deploy Preview https://deploy-preview-196--cwl-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good! Rendered the site locally, entered the URL manually as the navigation menu points to the production site.

image

Clicking on the link returns an error page,

image

Adding the .html in the browser fixed it. Not sure if that's needed for GitHub Pages, or if there the deployment will be slightly different.

Thanks!

image

{: .table .table-striped .cols-2 }
|Name|Scope|
|--- |--- |
|[CWL4HPC](/working-groups/cwl4hpc) | Identify workflow patterns capable of modeling large-scale scientific applications and implement the related CWL enhancement proposals.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the link needs the .html suffix?

@GlassOfWhiskey GlassOfWhiskey force-pushed the add-working-groups-section branch 2 times, most recently from 2c21978 to 17763f1 Compare February 14, 2024 14:57
- Motivate it with two real use cases that would benefit from the proposed feature;
- Agree on a first draft of the syntax and semantics of the proposed feature;
- Implement it as an extension on `cwltool` (the CWL reference implementation) and at least another CWL-compliant workflow system;
- Validate it on at least two real CWL workflows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for existing workflows? How real does it need to be? I think maybe this could be difficult, @GlassOfWhiskey if we are adding something new like loops, cycles, ordered steps, anything new, maybe these new features do not work with existing workflows, and maybe we don't have any public workflow to be re-written with CWL and this new feature.

Maybe "Validate it on at least two existing CWL workflows where the proposal is applied, or with new example workflows created for this" (and maybe add it to the standard battery of tests?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. Better specifying it. I also forgot to add the test suite to the implementation part. I'll rephrase it

This commit adds a Working Groups section to track CWL focus groups
on specific topics. The CWL4HPC working group has been added as an
example, hoping that more activities will come in the future.
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read the latest changes, and it looks ready to be merged IMHO! THanks @GlassOfWhiskey !

@GlassOfWhiskey GlassOfWhiskey marked this pull request as ready for review February 14, 2024 16:31
@mr-c mr-c merged commit 2d0d16e into main Feb 14, 2024
7 checks passed
@mr-c mr-c deleted the add-working-groups-section branch February 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants