Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwltool fails when node is not installed #267

Closed
StarvingMarvin opened this issue Jan 7, 2017 · 4 comments
Closed

cwltool fails when node is not installed #267

StarvingMarvin opened this issue Jan 7, 2017 · 4 comments
Assignees

Comments

@StarvingMarvin
Copy link
Member

The error I got was:

AttributeError: 'LineCol' object has no attribute 'filename'

Which is not very descriptive. Also install instructions doesn't mention nodejs as a dependency.

@psaffrey-illumina
Copy link
Contributor

I've had this error too:

#264

I think it occurs for quite a variety of errors when the error reporting itself fails due to a lack of reference to the source file for the error. If you run cwltool with the Python debugger and break on this line, you can output the msg variable which contains something a lot more useful.

I wanted to try to put together a fix for this but I wasn't sure why the file might be going missing.

@anton-khodak
Copy link
Member

anton-khodak commented Feb 3, 2017

+ for outputting msg variable. Would be good if it was an explicit error message

qiukunlong pushed a commit to qiukunlong/cwltool that referenced this issue Mar 25, 2017
46ce0c3 Merge pull request common-workflow-language#265 from common-workflow-language/optional-baseCommand
64774b2 Merge pull request common-workflow-language#271 from kislyuk/patch-1
dc8ac51 add description->doc to release notes
8189f03 Update contrib.md
5b7ad26 Merge pull request common-workflow-language#263 from common-workflow-language/better-writable-test
1d5714d Merge pull request common-workflow-language#268 from chapmanb/tests-docker-hints
4b78524 Merge pull request common-workflow-language#267 from common-workflow-language/test-nameroot-in-stdout
7d45aca Tests: move Docker from requirements to hints
c95d302 Add test using $(inputs.file.nameroot) in stdout field.
66046d1 Errata: make baseCommand optional because the text did not specify if "baseCommand: []" is legal, but functionally "baseCommand: []" has the same effect as not providing baseCommand at all.
c807103 Adjust conformance test for "writable" flag.  Previous test did not test intended behavior because 'sed -i' doesn't modify the file in place.
c256c08 update CITATION to v1.0
98da9c1 bump DOI version
e4daf25 errata: SoftwarePackage 'name' conflicts; use 'package'
5619853 errata: SoftwarePackage packages is a required array
9a6a044 last update to test 72
5932a26 Merge pull request common-workflow-language#261 from common-workflow-language/mr-c-patch-1
bc38b68 match new SoftwareRequirement syntax
e065755 Merge pull request common-workflow-language#260 from StarvingMarvin/master
af25c0a Making stronger promise on runtime values that platform provides
de7a9ca update link to user guide
3db2c7c Add missing file
5eae857 Merge branch 'master' into userguide-1.0
0071e84 Update user guide for v1.0
f3d7dce Merge pull request common-workflow-language#257 from StarvingMarvin/master
111df5b deleted repeated words
01286d2 Merge pull request common-workflow-language#256 from common-workflow-language/release-notes
7889ab2 update URL to v1.0
e2aeceb format map<>
ac1ad16 corrent URL to v1.0
53cf86d clarify map feature
70a076a update release notes
ce50dfd Merge pull request common-workflow-language#255 from common-workflow-language/matt-edits
db11e6e last edits
fa84959 update contribs
5fa3867 Build user guide.  Bugfix user guide.
08ea290 last Matt edits
9686fde Merge branch 'master' into userguide-1.0
adda389 cwlsite v1.0.dev4 -> v1.0
c1bd238 fix typo
b7b0355 more edits
fbe0e8b typo
ab83ec2 update my affiliation and email address
c25dfc9 More edits
901ea7c Merge branch 'master' into userguide-1.0
156d28f Update examples to v1.0
5403799 Add examples
4fcf203 Copy draft-3 user guide.
c113a39 Tests are v1.0
0fbc47b Add v1.0 as real valid version.

git-subtree-dir: cwltool/schemas
git-subtree-split: 46ce0c3
@manu-chroma manu-chroma self-assigned this Jul 16, 2017
@kapilkd13
Copy link
Contributor

Hi @StarvingMarvin Usually when I use Javascript expression with InlineJavascriptRequirement and node is not installed then cwltool try to create a node Docker Container and it works. Is this related to InlineJsrequirement. I think I am missing something.

@mr-c
Copy link
Member

mr-c commented Jul 18, 2017

Looks like this was fixed in common-workflow-language/schema_salad#85. Feel free to re-open if it happens again

@mr-c mr-c closed this as completed Jul 18, 2017
tetron pushed a commit that referenced this issue Jul 23, 2017
…n-stdout

Add test using $(inputs.file.nameroot) in stdout field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants