tests: reduce number of software containers #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 66.45% 66.49% +0.04%
==========================================
Files 89 89
Lines 15908 15908
Branches 4216 4216
==========================================
+ Hits 10571 10578 +7
+ Misses 4238 4229 -9
- Partials 1099 1101 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
As inspired by the list at https://github.com/common-workflow-language/cwl-v1.2/blob/1.2.1_proposed/CONFORMANCE_TESTS.md#writing-a-new-conformance-test Also fixes a Singularity 3 bug
mr-c
commented
Aug 19, 2022
| @@ -184,7 +184,7 @@ def get_image( | |||
| candidates.append(dockerRequirement["dockerImageId"]) | |||
| candidates.append(_normalize_image_id(dockerRequirement["dockerImageId"])) | |||
| if is_version_3_or_newer(): | |||
| candidates.append(_normalize_sif_id(dockerRequirement["dockerPull"])) | |||
| candidates.append(_normalize_sif_id(dockerRequirement["dockerImageId"])) | |||
GlassOfWhiskey
pushed a commit
that referenced
this pull request
Sep 15, 2022
As inspired by the list at https://github.com/common-workflow-language/cwl-v1.2/blob/1.2.1_proposed/CONFORMANCE_TESTS.md#writing-a-new-conformance-test Also fixes a Singularity 3 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As inspired by the list at
https://github.com/common-workflow-language/cwl-v1.2/blob/1.2.1_proposed/CONFORMANCE_TESTS.md#writing-a-new-conformance-test
Also fixes a Singularity 3 bug